* [PATCH 02/20] Input: bf54x-keys - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
@ 2013-05-06 4:23 ` Sachin Kamat
2013-05-06 4:23 ` [PATCH 03/20] Input: davinci_keyscan " Sachin Kamat
` (17 subsequent siblings)
18 siblings, 0 replies; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:23 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, Michael Hennerich
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Michael Hennerich <hennerich@blackfin.uclinux.org>
---
drivers/input/keyboard/bf54x-keys.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/keyboard/bf54x-keys.c b/drivers/input/keyboard/bf54x-keys.c
index 20b9fa9..fc88fb4 100644
--- a/drivers/input/keyboard/bf54x-keys.c
+++ b/drivers/input/keyboard/bf54x-keys.c
@@ -326,7 +326,6 @@ out0:
kfree(bf54x_kpad->keycode);
out:
kfree(bf54x_kpad);
- platform_set_drvdata(pdev, NULL);
return error;
}
@@ -346,7 +345,6 @@ static int bfin_kpad_remove(struct platform_device *pdev)
kfree(bf54x_kpad->keycode);
kfree(bf54x_kpad);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 03/20] Input: davinci_keyscan - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
2013-05-06 4:23 ` [PATCH 02/20] Input: bf54x-keys " Sachin Kamat
@ 2013-05-06 4:23 ` Sachin Kamat
2013-05-06 4:23 ` [PATCH 04/20] Input: ep93xx_keypad " Sachin Kamat
` (16 subsequent siblings)
18 siblings, 0 replies; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:23 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, Miguel Aguilar
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Miguel Aguilar <miguel.aguilar@ridgerun.com>
---
drivers/input/keyboard/davinci_keyscan.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/keyboard/davinci_keyscan.c b/drivers/input/keyboard/davinci_keyscan.c
index 8297537..d15977a 100644
--- a/drivers/input/keyboard/davinci_keyscan.c
+++ b/drivers/input/keyboard/davinci_keyscan.c
@@ -314,8 +314,6 @@ static int davinci_ks_remove(struct platform_device *pdev)
iounmap(davinci_ks->base);
release_mem_region(davinci_ks->pbase, davinci_ks->base_size);
- platform_set_drvdata(pdev, NULL);
-
kfree(davinci_ks);
return 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 04/20] Input: ep93xx_keypad - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
2013-05-06 4:23 ` [PATCH 02/20] Input: bf54x-keys " Sachin Kamat
2013-05-06 4:23 ` [PATCH 03/20] Input: davinci_keyscan " Sachin Kamat
@ 2013-05-06 4:23 ` Sachin Kamat
2013-05-06 16:45 ` H Hartley Sweeten
2013-05-06 4:23 ` [PATCH 05/20] Input: gpio_keys " Sachin Kamat
` (15 subsequent siblings)
18 siblings, 1 reply; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:23 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, H Hartley Sweeten
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
---
drivers/input/keyboard/ep93xx_keypad.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c
index 9857e8f..a8d5aac 100644
--- a/drivers/input/keyboard/ep93xx_keypad.c
+++ b/drivers/input/keyboard/ep93xx_keypad.c
@@ -330,7 +330,6 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
failed_free_irq:
free_irq(keypad->irq, pdev);
- platform_set_drvdata(pdev, NULL);
failed_free_dev:
input_free_device(input_dev);
failed_put_clk:
@@ -353,8 +352,6 @@ static int ep93xx_keypad_remove(struct platform_device *pdev)
free_irq(keypad->irq, pdev);
- platform_set_drvdata(pdev, NULL);
-
if (keypad->enabled)
clk_disable(keypad->clk);
clk_put(keypad->clk);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* RE: [PATCH 04/20] Input: ep93xx_keypad - Remove redundant platform_set_drvdata()
2013-05-06 4:23 ` [PATCH 04/20] Input: ep93xx_keypad " Sachin Kamat
@ 2013-05-06 16:45 ` H Hartley Sweeten
0 siblings, 0 replies; 23+ messages in thread
From: H Hartley Sweeten @ 2013-05-06 16:45 UTC (permalink / raw)
To: Sachin Kamat, linux-input@vger.kernel.org; +Cc: dmitry.torokhov@gmail.com
On Sunday, May 05, 2013 9:24 PM, Sachin Kamat wrote:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
> ---
> drivers/input/keyboard/ep93xx_keypad.c | 3 ---
> 1 file changed, 3 deletions(-)
Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 05/20] Input: gpio_keys - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
` (2 preceding siblings ...)
2013-05-06 4:23 ` [PATCH 04/20] Input: ep93xx_keypad " Sachin Kamat
@ 2013-05-06 4:23 ` Sachin Kamat
2013-05-06 4:23 ` [PATCH 06/20] Input: gpio_keys_polled " Sachin Kamat
` (14 subsequent siblings)
18 siblings, 0 replies; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:23 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, Phil Blundell
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Phil Blundell <pb@handhelds.org>
---
drivers/input/keyboard/gpio_keys.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index b29ca65..440ce32 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -767,7 +767,6 @@ static int gpio_keys_probe(struct platform_device *pdev)
while (--i >= 0)
gpio_remove_key(&ddata->data[i]);
- platform_set_drvdata(pdev, NULL);
fail1:
input_free_device(input);
kfree(ddata);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 06/20] Input: gpio_keys_polled - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
` (3 preceding siblings ...)
2013-05-06 4:23 ` [PATCH 05/20] Input: gpio_keys " Sachin Kamat
@ 2013-05-06 4:23 ` Sachin Kamat
2013-05-06 4:23 ` [PATCH 07/20] Input: jornada680_kbd " Sachin Kamat
` (13 subsequent siblings)
18 siblings, 0 replies; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:23 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, Gabor Juhos
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Gabor Juhos <juhosg@openwrt.org>
---
drivers/input/keyboard/gpio_keys_polled.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/keyboard/gpio_keys_polled.c b/drivers/input/keyboard/gpio_keys_polled.c
index 2114716..cd5ed9e 100644
--- a/drivers/input/keyboard/gpio_keys_polled.c
+++ b/drivers/input/keyboard/gpio_keys_polled.c
@@ -324,7 +324,6 @@ err_free_gpio:
err_free_bdev:
kfree(bdev);
- platform_set_drvdata(pdev, NULL);
err_free_pdata:
/* If we have no platform_data, we allocated pdata dynamically. */
@@ -355,7 +354,6 @@ static int gpio_keys_polled_remove(struct platform_device *pdev)
kfree(pdata);
kfree(bdev);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 07/20] Input: jornada680_kbd - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
` (4 preceding siblings ...)
2013-05-06 4:23 ` [PATCH 06/20] Input: gpio_keys_polled " Sachin Kamat
@ 2013-05-06 4:23 ` Sachin Kamat
2013-05-06 4:23 ` [PATCH 08/20] Input: jornada720_kbd " Sachin Kamat
` (12 subsequent siblings)
18 siblings, 0 replies; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:23 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, Kristoffer Ericson
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>
---
drivers/input/keyboard/jornada680_kbd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/keyboard/jornada680_kbd.c b/drivers/input/keyboard/jornada680_kbd.c
index 74e75a6..a2a034c 100644
--- a/drivers/input/keyboard/jornada680_kbd.c
+++ b/drivers/input/keyboard/jornada680_kbd.c
@@ -233,7 +233,6 @@ static int jornada680kbd_probe(struct platform_device *pdev)
failed:
printk(KERN_ERR "Jornadakbd: failed to register driver, error: %d\n",
error);
- platform_set_drvdata(pdev, NULL);
input_free_polled_device(poll_dev);
kfree(jornadakbd);
return error;
@@ -244,7 +243,6 @@ static int jornada680kbd_remove(struct platform_device *pdev)
{
struct jornadakbd *jornadakbd = platform_get_drvdata(pdev);
- platform_set_drvdata(pdev, NULL);
input_unregister_polled_device(jornadakbd->poll_dev);
input_free_polled_device(jornadakbd->poll_dev);
kfree(jornadakbd);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 08/20] Input: jornada720_kbd - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
` (5 preceding siblings ...)
2013-05-06 4:23 ` [PATCH 07/20] Input: jornada680_kbd " Sachin Kamat
@ 2013-05-06 4:23 ` Sachin Kamat
2013-05-06 4:23 ` [PATCH 09/20] Input: matrix_keypad " Sachin Kamat
` (11 subsequent siblings)
18 siblings, 0 replies; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:23 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, Kristoffer Ericson
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Kristoffer Ericson <Kristoffer.Ericson@gmail.com>
---
drivers/input/keyboard/jornada720_kbd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/keyboard/jornada720_kbd.c b/drivers/input/keyboard/jornada720_kbd.c
index 5ceef63..b0ad457 100644
--- a/drivers/input/keyboard/jornada720_kbd.c
+++ b/drivers/input/keyboard/jornada720_kbd.c
@@ -146,7 +146,6 @@ static int jornada720_kbd_probe(struct platform_device *pdev)
fail2: /* IRQ, DEVICE, MEMORY */
free_irq(IRQ_GPIO0, pdev);
fail1: /* DEVICE, MEMORY */
- platform_set_drvdata(pdev, NULL);
input_free_device(input_dev);
kfree(jornadakbd);
return err;
@@ -157,7 +156,6 @@ static int jornada720_kbd_remove(struct platform_device *pdev)
struct jornadakbd *jornadakbd = platform_get_drvdata(pdev);
free_irq(IRQ_GPIO0, pdev);
- platform_set_drvdata(pdev, NULL);
input_unregister_device(jornadakbd->input);
kfree(jornadakbd);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 09/20] Input: matrix_keypad - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
` (6 preceding siblings ...)
2013-05-06 4:23 ` [PATCH 08/20] Input: jornada720_kbd " Sachin Kamat
@ 2013-05-06 4:23 ` Sachin Kamat
2013-05-06 12:08 ` Marek Vasut
2013-05-06 4:23 ` [PATCH 10/20] Input: omap4-keypad " Sachin Kamat
` (10 subsequent siblings)
18 siblings, 1 reply; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:23 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, Marek Vasut
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Marek Vasut <marek.vasut@gmail.com>
---
drivers/input/keyboard/matrix_keypad.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c
index 71d7719..90ff73a 100644
--- a/drivers/input/keyboard/matrix_keypad.c
+++ b/drivers/input/keyboard/matrix_keypad.c
@@ -549,8 +549,6 @@ static int matrix_keypad_remove(struct platform_device *pdev)
input_unregister_device(keypad->input_dev);
kfree(keypad);
- platform_set_drvdata(pdev, NULL);
-
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [PATCH 09/20] Input: matrix_keypad - Remove redundant platform_set_drvdata()
2013-05-06 4:23 ` [PATCH 09/20] Input: matrix_keypad " Sachin Kamat
@ 2013-05-06 12:08 ` Marek Vasut
0 siblings, 0 replies; 23+ messages in thread
From: Marek Vasut @ 2013-05-06 12:08 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-input, dmitry.torokhov
Dear Sachin Kamat,
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Marek Vasut <marek.vasut@gmail.com>
It does make sense.
btw. if you're up to cleaning this up, you can also introduce some
devm_input_device_allocate() and switch kzalloc() to devm_kzalloc etc.
> ---
> drivers/input/keyboard/matrix_keypad.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/matrix_keypad.c
> b/drivers/input/keyboard/matrix_keypad.c index 71d7719..90ff73a 100644
> --- a/drivers/input/keyboard/matrix_keypad.c
> +++ b/drivers/input/keyboard/matrix_keypad.c
> @@ -549,8 +549,6 @@ static int matrix_keypad_remove(struct platform_device
> *pdev) input_unregister_device(keypad->input_dev);
> kfree(keypad);
>
> - platform_set_drvdata(pdev, NULL);
> -
> return 0;
> }
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 10/20] Input: omap4-keypad - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
` (7 preceding siblings ...)
2013-05-06 4:23 ` [PATCH 09/20] Input: matrix_keypad " Sachin Kamat
@ 2013-05-06 4:23 ` Sachin Kamat
2013-05-06 4:23 ` [PATCH 11/20] Input: opencores-kbd " Sachin Kamat
` (9 subsequent siblings)
18 siblings, 0 replies; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:23 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/input/keyboard/omap4-keypad.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c
index 1b28909..f4aa53a 100644
--- a/drivers/input/keyboard/omap4-keypad.c
+++ b/drivers/input/keyboard/omap4-keypad.c
@@ -419,8 +419,6 @@ static int omap4_keypad_remove(struct platform_device *pdev)
kfree(keypad_data->keymap);
kfree(keypad_data);
- platform_set_drvdata(pdev, NULL);
-
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 11/20] Input: opencores-kbd - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
` (8 preceding siblings ...)
2013-05-06 4:23 ` [PATCH 10/20] Input: omap4-keypad " Sachin Kamat
@ 2013-05-06 4:23 ` Sachin Kamat
2013-05-06 4:23 ` [PATCH 12/20] Input: pmic8xxx-keypad " Sachin Kamat
` (8 subsequent siblings)
18 siblings, 0 replies; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:23 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, Javier Herrero
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Javier Herrero <jherrero@hvsistemas.es>
---
drivers/input/keyboard/opencores-kbd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/keyboard/opencores-kbd.c b/drivers/input/keyboard/opencores-kbd.c
index 7ac5f17..7b9b441 100644
--- a/drivers/input/keyboard/opencores-kbd.c
+++ b/drivers/input/keyboard/opencores-kbd.c
@@ -151,8 +151,6 @@ static int opencores_kbd_remove(struct platform_device *pdev)
input_unregister_device(opencores_kbd->input);
kfree(opencores_kbd);
- platform_set_drvdata(pdev, NULL);
-
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 12/20] Input: pmic8xxx-keypad - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
` (9 preceding siblings ...)
2013-05-06 4:23 ` [PATCH 11/20] Input: opencores-kbd " Sachin Kamat
@ 2013-05-06 4:23 ` Sachin Kamat
2013-05-06 4:23 ` [PATCH 13/20] Input: pxa27x_keypad " Sachin Kamat
` (7 subsequent siblings)
18 siblings, 0 replies; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:23 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, Trilok Soni
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Trilok Soni <tsoni@codeaurora.org>
---
drivers/input/keyboard/pmic8xxx-keypad.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/keyboard/pmic8xxx-keypad.c b/drivers/input/keyboard/pmic8xxx-keypad.c
index 74339e1..2c9f19a 100644
--- a/drivers/input/keyboard/pmic8xxx-keypad.c
+++ b/drivers/input/keyboard/pmic8xxx-keypad.c
@@ -707,7 +707,6 @@ err_gpio_config:
err_get_irq:
input_free_device(kp->input);
err_alloc_device:
- platform_set_drvdata(pdev, NULL);
kfree(kp);
return rc;
}
@@ -722,7 +721,6 @@ static int pmic8xxx_kp_remove(struct platform_device *pdev)
input_unregister_device(kp->input);
kfree(kp);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 13/20] Input: pxa27x_keypad - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
` (10 preceding siblings ...)
2013-05-06 4:23 ` [PATCH 12/20] Input: pmic8xxx-keypad " Sachin Kamat
@ 2013-05-06 4:23 ` Sachin Kamat
2013-05-06 4:23 ` [PATCH 14/20] Input: pxa930_rotary " Sachin Kamat
` (6 subsequent siblings)
18 siblings, 0 replies; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:23 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, Rodolfo Giometti
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Rodolfo Giometti <giometti@linux.it>
---
drivers/input/keyboard/pxa27x_keypad.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/keyboard/pxa27x_keypad.c b/drivers/input/keyboard/pxa27x_keypad.c
index 5330d8f..74e30cc 100644
--- a/drivers/input/keyboard/pxa27x_keypad.c
+++ b/drivers/input/keyboard/pxa27x_keypad.c
@@ -609,7 +609,6 @@ static int pxa27x_keypad_remove(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
release_mem_region(res->start, resource_size(res));
- platform_set_drvdata(pdev, NULL);
kfree(keypad);
return 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 14/20] Input: pxa930_rotary - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
` (11 preceding siblings ...)
2013-05-06 4:23 ` [PATCH 13/20] Input: pxa27x_keypad " Sachin Kamat
@ 2013-05-06 4:23 ` Sachin Kamat
2013-05-06 4:23 ` [PATCH 15/20] Input: samsung-keypad " Sachin Kamat
` (5 subsequent siblings)
18 siblings, 0 replies; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:23 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, Yao Yong
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Yao Yong <yaoyong@marvell.com>
---
drivers/input/keyboard/pxa930_rotary.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/keyboard/pxa930_rotary.c b/drivers/input/keyboard/pxa930_rotary.c
index bcad95b..248cdcf 100644
--- a/drivers/input/keyboard/pxa930_rotary.c
+++ b/drivers/input/keyboard/pxa930_rotary.c
@@ -181,7 +181,6 @@ static int pxa930_rotary_remove(struct platform_device *pdev)
free_irq(platform_get_irq(pdev, 0), r);
input_unregister_device(r->input_dev);
iounmap(r->mmio_base);
- platform_set_drvdata(pdev, NULL);
kfree(r);
return 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 15/20] Input: samsung-keypad - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
` (12 preceding siblings ...)
2013-05-06 4:23 ` [PATCH 14/20] Input: pxa930_rotary " Sachin Kamat
@ 2013-05-06 4:23 ` Sachin Kamat
2013-05-06 4:23 ` [PATCH 16/20] Input: sh_keysc " Sachin Kamat
` (4 subsequent siblings)
18 siblings, 0 replies; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:23 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, Joonyoung Shim
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>
---
drivers/input/keyboard/samsung-keypad.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/keyboard/samsung-keypad.c b/drivers/input/keyboard/samsung-keypad.c
index 22e357b..7b938b4 100644
--- a/drivers/input/keyboard/samsung-keypad.c
+++ b/drivers/input/keyboard/samsung-keypad.c
@@ -487,7 +487,6 @@ static int samsung_keypad_probe(struct platform_device *pdev)
err_disable_runtime_pm:
pm_runtime_disable(&pdev->dev);
device_init_wakeup(&pdev->dev, 0);
- platform_set_drvdata(pdev, NULL);
err_unprepare_clk:
clk_unprepare(keypad->clk);
return error;
@@ -499,7 +498,6 @@ static int samsung_keypad_remove(struct platform_device *pdev)
pm_runtime_disable(&pdev->dev);
device_init_wakeup(&pdev->dev, 0);
- platform_set_drvdata(pdev, NULL);
input_unregister_device(keypad->input_dev);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 16/20] Input: sh_keysc - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
` (13 preceding siblings ...)
2013-05-06 4:23 ` [PATCH 15/20] Input: samsung-keypad " Sachin Kamat
@ 2013-05-06 4:23 ` Sachin Kamat
2013-05-06 4:23 ` [PATCH 17/20] Input: spear-keyboard " Sachin Kamat
` (3 subsequent siblings)
18 siblings, 0 replies; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:23 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/input/keyboard/sh_keysc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/keyboard/sh_keysc.c b/drivers/input/keyboard/sh_keysc.c
index fdb9eb2..fe0e498 100644
--- a/drivers/input/keyboard/sh_keysc.c
+++ b/drivers/input/keyboard/sh_keysc.c
@@ -266,7 +266,6 @@ static int sh_keysc_probe(struct platform_device *pdev)
err2:
iounmap(priv->iomem_base);
err1:
- platform_set_drvdata(pdev, NULL);
kfree(priv);
err0:
return error;
@@ -285,7 +284,6 @@ static int sh_keysc_remove(struct platform_device *pdev)
pm_runtime_put_sync(&pdev->dev);
pm_runtime_disable(&pdev->dev);
- platform_set_drvdata(pdev, NULL);
kfree(priv);
return 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 17/20] Input: spear-keyboard - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
` (14 preceding siblings ...)
2013-05-06 4:23 ` [PATCH 16/20] Input: sh_keysc " Sachin Kamat
@ 2013-05-06 4:23 ` Sachin Kamat
2013-05-13 4:04 ` Viresh Kumar
2013-05-06 4:23 ` [PATCH 18/20] Input: tnetv107x-keypad " Sachin Kamat
` (2 subsequent siblings)
18 siblings, 1 reply; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:23 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, Viresh Kumar
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/input/keyboard/spear-keyboard.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/keyboard/spear-keyboard.c b/drivers/input/keyboard/spear-keyboard.c
index cb1e8f6..7111124 100644
--- a/drivers/input/keyboard/spear-keyboard.c
+++ b/drivers/input/keyboard/spear-keyboard.c
@@ -290,7 +290,6 @@ static int spear_kbd_remove(struct platform_device *pdev)
clk_unprepare(kbd->clk);
device_init_wakeup(&pdev->dev, 0);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [PATCH 17/20] Input: spear-keyboard - Remove redundant platform_set_drvdata()
2013-05-06 4:23 ` [PATCH 17/20] Input: spear-keyboard " Sachin Kamat
@ 2013-05-13 4:04 ` Viresh Kumar
0 siblings, 0 replies; 23+ messages in thread
From: Viresh Kumar @ 2013-05-13 4:04 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-input, dmitry.torokhov
On 6 May 2013 09:53, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/input/keyboard/spear-keyboard.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/spear-keyboard.c b/drivers/input/keyboard/spear-keyboard.c
> index cb1e8f6..7111124 100644
> --- a/drivers/input/keyboard/spear-keyboard.c
> +++ b/drivers/input/keyboard/spear-keyboard.c
> @@ -290,7 +290,6 @@ static int spear_kbd_remove(struct platform_device *pdev)
> clk_unprepare(kbd->clk);
>
> device_init_wakeup(&pdev->dev, 0);
> - platform_set_drvdata(pdev, NULL);
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 18/20] Input: tnetv107x-keypad - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
` (15 preceding siblings ...)
2013-05-06 4:23 ` [PATCH 17/20] Input: spear-keyboard " Sachin Kamat
@ 2013-05-06 4:23 ` Sachin Kamat
2013-05-06 4:23 ` [PATCH 19/20] Input: twl4030_keypad " Sachin Kamat
2013-05-06 4:24 ` [PATCH 20/20] Input: w90p910_keypad " Sachin Kamat
18 siblings, 0 replies; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:23 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/input/keyboard/tnetv107x-keypad.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/keyboard/tnetv107x-keypad.c b/drivers/input/keyboard/tnetv107x-keypad.c
index ee16350..5f7b427 100644
--- a/drivers/input/keyboard/tnetv107x-keypad.c
+++ b/drivers/input/keyboard/tnetv107x-keypad.c
@@ -296,7 +296,6 @@ error_clk:
error_map:
release_mem_region(kp->res->start, resource_size(kp->res));
error_res:
- platform_set_drvdata(pdev, NULL);
kfree(kp);
return error;
}
@@ -311,7 +310,6 @@ static int keypad_remove(struct platform_device *pdev)
clk_put(kp->clk);
iounmap(kp->regs);
release_mem_region(kp->res->start, resource_size(kp->res));
- platform_set_drvdata(pdev, NULL);
kfree(kp);
return 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 19/20] Input: twl4030_keypad - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
` (16 preceding siblings ...)
2013-05-06 4:23 ` [PATCH 18/20] Input: tnetv107x-keypad " Sachin Kamat
@ 2013-05-06 4:23 ` Sachin Kamat
2013-05-06 4:24 ` [PATCH 20/20] Input: w90p910_keypad " Sachin Kamat
18 siblings, 0 replies; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:23 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/input/keyboard/twl4030_keypad.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/keyboard/twl4030_keypad.c b/drivers/input/keyboard/twl4030_keypad.c
index 04f84fd..f05ee1db 100644
--- a/drivers/input/keyboard/twl4030_keypad.c
+++ b/drivers/input/keyboard/twl4030_keypad.c
@@ -438,7 +438,6 @@ static int twl4030_kp_remove(struct platform_device *pdev)
free_irq(kp->irq, kp);
input_unregister_device(kp->input);
- platform_set_drvdata(pdev, NULL);
kfree(kp);
return 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 20/20] Input: w90p910_keypad - Remove redundant platform_set_drvdata()
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
` (17 preceding siblings ...)
2013-05-06 4:23 ` [PATCH 19/20] Input: twl4030_keypad " Sachin Kamat
@ 2013-05-06 4:24 ` Sachin Kamat
18 siblings, 0 replies; 23+ messages in thread
From: Sachin Kamat @ 2013-05-06 4:24 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, Wan ZongShun
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Wan ZongShun <mcuos.com@gmail.com>
---
drivers/input/keyboard/w90p910_keypad.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/keyboard/w90p910_keypad.c b/drivers/input/keyboard/w90p910_keypad.c
index ee163be..72e6a56 100644
--- a/drivers/input/keyboard/w90p910_keypad.c
+++ b/drivers/input/keyboard/w90p910_keypad.c
@@ -249,7 +249,6 @@ static int w90p910_keypad_remove(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
release_mem_region(res->start, resource_size(res));
- platform_set_drvdata(pdev, NULL);
kfree(keypad);
return 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 23+ messages in thread