* [PATCHv2] hid: remove duplicate ID for D-WAV eGalax 0x7224 [not found] <1367936944-1624?= =?ISO-8859-1?Q?9-2-git-send-ema?= =?ISO-8859-1?Q?il-andriy.shevch?= =?ISO-8859-1?Q?enko@linux.intel?= =?ISO-8859-1?Q?.com=1B[B=1B[B=1B[B> @ 2013-05-07 14:38 ` Andy Shevchenko 2013-05-07 14:48 ` Benjamin Tissoires 0 siblings, 1 reply; 5+ messages in thread From: Andy Shevchenko @ 2013-05-07 14:38 UTC (permalink / raw) To: Jiri Kosina, linux-input, Benjamin Tissoires; +Cc: Andy Shevchenko Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/hid/hid-ids.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 2378a0b..a5520ba 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -268,7 +268,6 @@ #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7207 0x7207 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_720C 0x720c #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224 0x7224 -#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224 0x7224 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_722A 0x722A #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_725E 0x725e #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7262 0x7262 -- 1.8.2.rc0.22.gb3600c3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCHv2] hid: remove duplicate ID for D-WAV eGalax 0x7224 2013-05-07 14:38 ` [PATCHv2] hid: remove duplicate ID for D-WAV eGalax 0x7224 Andy Shevchenko @ 2013-05-07 14:48 ` Benjamin Tissoires 2013-05-08 7:23 ` Andy Shevchenko 0 siblings, 1 reply; 5+ messages in thread From: Benjamin Tissoires @ 2013-05-07 14:48 UTC (permalink / raw) To: Andy Shevchenko; +Cc: Jiri Kosina, linux-input On 05/07/2013 04:38 PM, Andy Shevchenko wrote: > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- I bet it will be easier to track for Jiri if you resend the full series: - the egalax reordering - the remove of the duplicate ID As mentioned previously, also remove the entry in hid-multitouch (the one containing MT_CLS_EGALAX, not the _SERIAL one). Cheers, Benjamin > drivers/hid/hid-ids.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h > index 2378a0b..a5520ba 100644 > --- a/drivers/hid/hid-ids.h > +++ b/drivers/hid/hid-ids.h > @@ -268,7 +268,6 @@ > #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7207 0x7207 > #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_720C 0x720c > #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224 0x7224 > -#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224 0x7224 > #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_722A 0x722A > #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_725E 0x725e > #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7262 0x7262 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv2] hid: remove duplicate ID for D-WAV eGalax 0x7224 2013-05-07 14:48 ` Benjamin Tissoires @ 2013-05-08 7:23 ` Andy Shevchenko 2013-05-13 9:21 ` Benjamin Tissoires 0 siblings, 1 reply; 5+ messages in thread From: Andy Shevchenko @ 2013-05-08 7:23 UTC (permalink / raw) To: Benjamin Tissoires; +Cc: Jiri Kosina, linux-input On Tue, 2013-05-07 at 16:48 +0200, Benjamin Tissoires wrote: > On 05/07/2013 04:38 PM, Andy Shevchenko wrote: > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > I bet it will be easier to track for Jiri if you resend the full series: > - the egalax reordering > - the remove of the duplicate ID > > As mentioned previously, also remove the entry in hid-multitouch (the > one containing MT_CLS_EGALAX, not the _SERIAL one). Then it repeats v1, doesn't it? The difference between MT_USB_DEVICE and HID_USB_DEVICE macros is in .group member. Does it somehow affect device matching? > > Cheers, > Benjamin > > > drivers/hid/hid-ids.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h > > index 2378a0b..a5520ba 100644 > > --- a/drivers/hid/hid-ids.h > > +++ b/drivers/hid/hid-ids.h > > @@ -268,7 +268,6 @@ > > #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7207 0x7207 > > #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_720C 0x720c > > #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224 0x7224 > > -#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224 0x7224 > > #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_722A 0x722A > > #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_725E 0x725e > > #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7262 0x7262 > > > -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv2] hid: remove duplicate ID for D-WAV eGalax 0x7224 2013-05-08 7:23 ` Andy Shevchenko @ 2013-05-13 9:21 ` Benjamin Tissoires 2013-05-13 11:55 ` Jiri Kosina 0 siblings, 1 reply; 5+ messages in thread From: Benjamin Tissoires @ 2013-05-13 9:21 UTC (permalink / raw) To: Andy Shevchenko; +Cc: Benjamin Tissoires, Jiri Kosina, linux-input On Wed, May 8, 2013 at 9:23 AM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Tue, 2013-05-07 at 16:48 +0200, Benjamin Tissoires wrote: >> On 05/07/2013 04:38 PM, Andy Shevchenko wrote: >> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> > --- >> >> I bet it will be easier to track for Jiri if you resend the full series: >> - the egalax reordering >> - the remove of the duplicate ID >> >> As mentioned previously, also remove the entry in hid-multitouch (the >> one containing MT_CLS_EGALAX, not the _SERIAL one). > > Then it repeats v1, doesn't it? I can not speak for Jiri, but IMO, it's easier to say: "Hey Jiri, pick up the patch series v3 for this topic", instead of "Hey Jiri, please pick the patch 1 from v1 and patch 2 from v4 about this topic." So I would say yes, repeat v1 but add a comment in the cover letter explaining the changes (for example, no changes in patch 1/2, patch 2/2 amended like this and that). > > The difference between MT_USB_DEVICE and HID_USB_DEVICE macros is > in .group member. Does it somehow affect device matching? > It does internally to some extend, but it won't change the final handling. MT_USB_DEVICE is cleaner because it will ask to grab only the MT interface. HID_USB_DEVICE will introduce a race with hid-generic to handle the non-MT interfaces, which are not present in the eGalax case IIRC. So basically, we just missed that HID_USB_ / MT_USB_ problem when including the patch upstream. Cheers, Benjamin ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv2] hid: remove duplicate ID for D-WAV eGalax 0x7224 2013-05-13 9:21 ` Benjamin Tissoires @ 2013-05-13 11:55 ` Jiri Kosina 0 siblings, 0 replies; 5+ messages in thread From: Jiri Kosina @ 2013-05-13 11:55 UTC (permalink / raw) To: Benjamin Tissoires; +Cc: Andy Shevchenko, Benjamin Tissoires, linux-input On Mon, 13 May 2013, Benjamin Tissoires wrote: > On Wed, May 8, 2013 at 9:23 AM, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Tue, 2013-05-07 at 16:48 +0200, Benjamin Tissoires wrote: > >> On 05/07/2013 04:38 PM, Andy Shevchenko wrote: > >> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > >> > --- > >> > >> I bet it will be easier to track for Jiri if you resend the full series: > >> - the egalax reordering > >> - the remove of the duplicate ID > >> > >> As mentioned previously, also remove the entry in hid-multitouch (the > >> one containing MT_CLS_EGALAX, not the _SERIAL one). > > > > Then it repeats v1, doesn't it? > > I can not speak for Jiri, but IMO, it's easier to say: > "Hey Jiri, pick up the patch series v3 for this topic", instead of > "Hey Jiri, please pick the patch 1 from v1 and patch 2 from v4 about > this topic." > > So I would say yes, repeat v1 but add a comment in the cover letter > explaining the changes (for example, no changes in patch 1/2, patch > 2/2 amended like this and that). Yes, exactly, please just do a fresh resend of the series with all the feedback incorporated. Thanks, -- Jiri Kosina SUSE Labs ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-13 11:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1367936944-1624?= =?ISO-8859-1?Q?9-2-git-send-ema?= =?ISO-8859-1?Q?il-andriy.shevch?= =?ISO-8859-1?Q?enko@linux.intel?= =?ISO-8859-1?Q?.com=1B[B=1B[B=1B[B>
2013-05-07 14:38 ` [PATCHv2] hid: remove duplicate ID for D-WAV eGalax 0x7224 Andy Shevchenko
2013-05-07 14:48 ` Benjamin Tissoires
2013-05-08 7:23 ` Andy Shevchenko
2013-05-13 9:21 ` Benjamin Tissoires
2013-05-13 11:55 ` Jiri Kosina
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).