From: Lars-Peter Clausen <lars@metafoo.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH 2/7] input: pxa27x_keypad: Pass correct pointer to free_irq()
Date: Mon, 20 May 2013 16:51:21 +0200 [thread overview]
Message-ID: <1369061486-28226-2-git-send-email-lars@metafoo.de> (raw)
In-Reply-To: <1369061486-28226-1-git-send-email-lars@metafoo.de>
free_irq() expects the same pointer that was passed to request_irq(), otherwise
the IRQ is not freed.
The issue was found using the following coccinelle script:
<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)
@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)
@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/input/keyboard/pxa27x_keypad.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/keyboard/pxa27x_keypad.c b/drivers/input/keyboard/pxa27x_keypad.c
index 74e30cc..b674e7a 100644
--- a/drivers/input/keyboard/pxa27x_keypad.c
+++ b/drivers/input/keyboard/pxa27x_keypad.c
@@ -582,7 +582,7 @@ static int pxa27x_keypad_probe(struct platform_device *pdev)
return 0;
failed_free_irq:
- free_irq(irq, pdev);
+ free_irq(irq, keypad);
failed_put_clk:
clk_put(keypad->clk);
failed_free_io:
@@ -600,7 +600,7 @@ static int pxa27x_keypad_remove(struct platform_device *pdev)
struct pxa27x_keypad *keypad = platform_get_drvdata(pdev);
struct resource *res;
- free_irq(keypad->irq, pdev);
+ free_irq(keypad->irq, keypad);
clk_put(keypad->clk);
input_unregister_device(keypad->input_dev);
--
1.8.0
next prev parent reply other threads:[~2013-05-20 14:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 14:51 [PATCH 1/7] input: ep93xx_keypad: Pass correct pointer to free_irq() Lars-Peter Clausen
2013-05-20 14:51 ` Lars-Peter Clausen [this message]
2013-05-20 14:51 ` [PATCH 3/7] input: twl4030_keypad: " Lars-Peter Clausen
2013-05-20 14:51 ` [PATCH 4/7] input: w90p910_keypad: " Lars-Peter Clausen
2013-05-20 14:51 ` [PATCH 5/7] input: ixp4xx-beeper: " Lars-Peter Clausen
2013-05-20 14:51 ` [PATCH 6/7] input: pmic8xxx-pwrkey: " Lars-Peter Clausen
2013-05-20 14:51 ` [PATCH 7/7] input: navpoint: " Lars-Peter Clausen
2013-05-20 15:49 ` [PATCH 1/7] input: ep93xx_keypad: " H Hartley Sweeten
2013-05-23 16:31 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369061486-28226-2-git-send-email-lars@metafoo.de \
--to=lars@metafoo.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).