From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: linux-input@vger.kernel.org
Cc: manishv.b@ti.com, davinci-linux-open-source@linux.davincidsp.com
Subject: [PATCH 1/3] Input: tps6507x-ts - use bool for booleans
Date: Sun, 9 Jun 2013 22:53:45 -0700 [thread overview]
Message-ID: <1370843627-30823-1-git-send-email-dmitry.torokhov@gmail.com> (raw)
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Note that neither of these 3 patches has been tested on the real hardware as
I don't have it so if someone could give them a spin that would be great.
drivers/input/touchscreen/tps6507x-ts.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c
index 1fb397c..c981ccf 100644
--- a/drivers/input/touchscreen/tps6507x-ts.c
+++ b/drivers/input/touchscreen/tps6507x-ts.c
@@ -45,12 +45,12 @@ struct tps6507x_ts {
struct ts_event tc;
struct tps6507x_dev *mfd;
u16 model;
- unsigned pendown;
+ u16 min_pressure;
int irq;
void (*clear_penirq)(void);
unsigned long poll_period; /* ms */
- u16 min_pressure;
int vref; /* non-zero to leave vref on */
+ bool pendown;
};
static int tps6507x_read_u8(struct tps6507x_ts *tsc, u8 reg, u8 *data)
@@ -165,12 +165,12 @@ static void tps6507x_ts_handler(struct work_struct *work)
struct tps6507x_ts *tsc = container_of(work,
struct tps6507x_ts, work.work);
struct input_dev *input_dev = tsc->input_dev;
- int pendown;
+ bool pendown;
int schd;
s32 ret;
- ret = tps6507x_adc_conversion(tsc, TPS6507X_TSCMODE_PRESSURE,
- &tsc->tc.pressure);
+ ret = tps6507x_adc_conversion(tsc, TPS6507X_TSCMODE_PRESSURE,
+ &tsc->tc.pressure);
if (ret)
goto done;
@@ -181,7 +181,7 @@ static void tps6507x_ts_handler(struct work_struct *work)
input_report_key(input_dev, BTN_TOUCH, 0);
input_report_abs(input_dev, ABS_PRESSURE, 0);
input_sync(input_dev);
- tsc->pendown = 0;
+ tsc->pendown = false;
}
if (pendown) {
@@ -206,7 +206,7 @@ static void tps6507x_ts_handler(struct work_struct *work)
input_report_abs(input_dev, ABS_Y, tsc->tc.y);
input_report_abs(input_dev, ABS_PRESSURE, tsc->tc.pressure);
input_sync(input_dev);
- tsc->pendown = 1;
+ tsc->pendown = true;
}
done:
--
1.8.1.4
next reply other threads:[~2013-06-10 5:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 5:53 Dmitry Torokhov [this message]
2013-06-10 5:53 ` [PATCH 2/3] Input: tps6507x-ts - remove vref from platform data Dmitry Torokhov
2013-07-02 15:49 ` Kevin Hilman
2013-06-10 5:53 ` [PATCH 3/3] Input: tps6507x-ts - convert to polled input device infrastructure Dmitry Torokhov
2013-06-12 7:12 ` Vishwanathrao Badarkhe, Manish
2013-06-19 6:17 ` Dmitry Torokhov
2013-07-01 6:42 ` Manish Badarkhe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370843627-30823-1-git-send-email-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-input@vger.kernel.org \
--cc=manishv.b@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).