linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oskar Andero <oskar.andero@sonymobile.com>
To: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>,
	Radovan Lekanovic <radovan.lekanovic@sonymobile.com>,
	Aleksej Makarov <aleksej.makarov@sonymobile.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Oskar Andero <oskar.andero@sonymobile.com>
Subject: [PATCH v2] input: don't call input_dev_release_keys() in resume
Date: Thu, 25 Jul 2013 14:09:14 +0200	[thread overview]
Message-ID: <1374754154-7990-1-git-send-email-oskar.andero@sonymobile.com> (raw)

From: Aleksej Makarov <aleksej.makarov@sonymobile.com>

When waking up the platform by pressing a specific key, sending a
release on that key makes it impossible to react on the event in
user-space. This is fixed by moving the input_reset_device() call to
resume instead.

Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Radovan Lekanovic <radovan.lekanovic@sonymobile.com>
Signed-off-by: Aleksej Makarov <aleksej.makarov@sonymobile.com>
Signed-off-by: Oskar Andero <oskar.andero@sonymobile.com>
---
 drivers/input/input.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/input/input.c b/drivers/input/input.c
index c044699..ee3ff16 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -1676,22 +1676,13 @@ static int input_dev_suspend(struct device *dev)
 {
 	struct input_dev *input_dev = to_input_dev(dev);
 
-	mutex_lock(&input_dev->mutex);
-
-	if (input_dev->users)
-		input_dev_toggle(input_dev, false);
-
-	mutex_unlock(&input_dev->mutex);
+	input_reset_device(input_dev);
 
 	return 0;
 }
 
 static int input_dev_resume(struct device *dev)
 {
-	struct input_dev *input_dev = to_input_dev(dev);
-
-	input_reset_device(input_dev);
-
 	return 0;
 }
 
-- 
1.8.1.5


             reply	other threads:[~2013-07-25 12:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 12:09 Oskar Andero [this message]
2013-09-18  9:10 ` [PATCH v2] input: don't call input_dev_release_keys() in resume Oskar Andero
  -- strict thread matches above, loose matches on Subject: below --
2013-11-22 13:27 Oskar Andero
2013-11-26  2:14 ` Dmitry Torokhov
2013-12-06  9:56   ` Oskar Andero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374754154-7990-1-git-send-email-oskar.andero@sonymobile.com \
    --to=oskar.andero@sonymobile.com \
    --cc=aleksej.makarov@sonymobile.com \
    --cc=bjorn.andersson@sonymobile.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=radovan.lekanovic@sonymobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).