* [PATCH] hid-holtekff: don't push static constants on stack for %*ph
@ 2013-08-02 11:08 Andy Shevchenko
2013-08-05 9:30 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2013-08-02 11:08 UTC (permalink / raw)
To: linux-input, Jiri Kosina; +Cc: Andy Shevchenko
There is no need to pass constants via stack. The width may be explicitly
specified in the format.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/hid/hid-holtekff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-holtekff.c b/drivers/hid/hid-holtekff.c
index 9a8f051..9325545 100644
--- a/drivers/hid/hid-holtekff.c
+++ b/drivers/hid/hid-holtekff.c
@@ -98,7 +98,7 @@ static void holtekff_send(struct holtekff_device *holtekff,
holtekff->field->value[i] = data[i];
}
- dbg_hid("sending %*ph\n", 7, data);
+ dbg_hid("sending %7ph\n", data);
hid_hw_request(hid, holtekff->field->report, HID_REQ_SET_REPORT);
}
--
1.8.4.rc0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] hid-holtekff: don't push static constants on stack for %*ph
2013-08-02 11:08 [PATCH] hid-holtekff: don't push static constants on stack for %*ph Andy Shevchenko
@ 2013-08-05 9:30 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2013-08-05 9:30 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-input
On Fri, 2 Aug 2013, Andy Shevchenko wrote:
> There is no need to pass constants via stack. The width may be explicitly
> specified in the format.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/hid/hid-holtekff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-holtekff.c b/drivers/hid/hid-holtekff.c
> index 9a8f051..9325545 100644
> --- a/drivers/hid/hid-holtekff.c
> +++ b/drivers/hid/hid-holtekff.c
> @@ -98,7 +98,7 @@ static void holtekff_send(struct holtekff_device *holtekff,
> holtekff->field->value[i] = data[i];
> }
>
> - dbg_hid("sending %*ph\n", 7, data);
> + dbg_hid("sending %7ph\n", data);
>
> hid_hw_request(hid, holtekff->field->report, HID_REQ_SET_REPORT);
Applied, thanks Andy.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-05 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-02 11:08 [PATCH] hid-holtekff: don't push static constants on stack for %*ph Andy Shevchenko
2013-08-05 9:30 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).