From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Achatz Subject: Re: [PATCH 35/36] hid: roccat: convert class code to use bin_attrs in groups Date: Thu, 15 Aug 2013 18:03:46 +0200 Message-ID: <1376582626.2452.26.camel@neuromancer.tessier-ashpool> Reply-To: erazor_de@users.sourceforge.net Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-in-13.arcor-online.net ([151.189.21.53]:45160 "EHLO mail-in-13.arcor-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753603Ab3HOQDu (ORCPT ); Thu, 15 Aug 2013 12:03:50 -0400 Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Greg Kroah-Hartman , Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Hello Greg, looking through the patch I found the following: In hid-roccat-kone.c, PROFILE_ATTR macro: The line .private = &profile_numbers[number], should read .private = &profile_numbers[number-1], Regarding the compiler warning about unused pyra_sysfs_write_settings: The attribute is indeed readwrite, but the code to write is not standard code. The read function was created with the PYRA_SYSFS_R macro and the write function was written manually. Used were both by PYRA_BIN_ATTRIBUTE_RW. In this case I would keep the PYRA_SYSFS_* macros standalone so that the calling code looks like this: PYRA_SYSFS_W(control, CONTROL); PYRA_SYSFS_RW(info, INFO); PYRA_SYSFS_RW(profile_settings, PROFILE_SETTINGS); PYRA_SYSFS_RW(profile_buttons, PROFILE_BUTTONS); PYRA_SYSFS_R(settings, SETTINGS); PYRA_BIN_ATTRIBUTE_W(control, CONTROL); PYRA_BIN_ATTRIBUTE_RW(info, INFO); PYRA_BIN_ATTRIBUTE_RW(profile_settings, PROFILE_SETTINGS); PYRA_BIN_ATTRIBUTE_RW(profile_buttons, PROFILE_BUTTONS); PYRA_BIN_ATTRIBUTE_RW(settings, SETTINGS); Another thing: Why does nobody (besides me) use the get_maintainer.pl script, so I have to search manually for patches regarding my code? Have a nice day, Stefan