linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gerecke <killertofu@gmail.com>
To: linuxwacom-devel@lists.sourceforge.net,
	linux-input@vger.kernel.org, pinglinux@gmail.com
Cc: Jason Gerecke <killertofu@gmail.com>
Subject: [PATCH 2/3] Input: wacom - Provide a range for the ABS_MISC axis
Date: Thu, 22 Aug 2013 18:15:36 -0700	[thread overview]
Message-ID: <1377220537-1474-2-git-send-email-killertofu@gmail.com> (raw)
In-Reply-To: <1377220537-1474-1-git-send-email-killertofu@gmail.com>

Android marks found axes as 'valid' only if they have a minimum
and maximum value that aren't equal. Since we don't actually
assign any range information for ABS_MISC, Android doesn't bother
to mark it such. This prevents userspace from being able to make
use of tool serial information.

Signed-off-by: Jason Gerecke <killertofu@gmail.com>
---
 drivers/input/tablet/wacom_wac.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
index 8ccfe91..869e9c9 100644
--- a/drivers/input/tablet/wacom_wac.c
+++ b/drivers/input/tablet/wacom_wac.c
@@ -1468,6 +1468,8 @@ static void wacom_abs_set_axis(struct input_dev *input_dev,
 {
 	struct wacom_features *features = &wacom_wac->features;
 
+	input_set_abs_params(input_dev, ABS_MISC, INT_MIN, INT_MAX, 0, 0);
+
 	if (features->device_type == BTN_TOOL_PEN) {
 		input_set_abs_params(input_dev, ABS_X, 0, features->x_max,
 				     features->x_fuzz, 0);
-- 
1.8.3.4


  reply	other threads:[~2013-08-23  1:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-23  1:15 [PATCH 1/3] Input: wacom - Support EMR and MFT sensors of Cintiq Companion Hybrid Jason Gerecke
2013-08-23  1:15 ` Jason Gerecke [this message]
2013-08-24 23:50   ` [PATCH 2/3] Input: wacom - Provide a range for the ABS_MISC axis Dmitry Torokhov
2013-08-25 17:43     ` Jason Gerecke
2013-08-23  1:15 ` [PATCH 3/3] Input: wacom - Send proper tablet state info when pen leaves proximity Jason Gerecke
2013-08-24 23:56 ` [PATCH 1/3] Input: wacom - Support EMR and MFT sensors of Cintiq Companion Hybrid Dmitry Torokhov
2013-08-26 17:13 ` [PATCH 1/3 v2] " Jason Gerecke
2013-08-29  1:10   ` Peter Hutterer
2013-09-03 21:52 ` [PATCH 1/3 v3] " Jason Gerecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377220537-1474-2-git-send-email-killertofu@gmail.com \
    --to=killertofu@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linuxwacom-devel@lists.sourceforge.net \
    --cc=pinglinux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).