linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Input: add SYN_MAX and SYN_CNT constants
@ 2013-08-27 11:23 David Herrmann
  2013-08-29  1:06 ` Peter Hutterer
  0 siblings, 1 reply; 2+ messages in thread
From: David Herrmann @ 2013-08-27 11:23 UTC (permalink / raw)
  To: linux-input; +Cc: Dmitry Torokhov, David Herrmann

SYN_* events are special and not enabled via set_bit() for devices. Hence,
they haven't been really needed, yet. However, user-space can still make
great use of that for int->string debugging helpers or alike.

Also, I haven't seen any reason not to define these, so here they are.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
---
 include/uapi/linux/input.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
index 4649ee3..2fb6fae 100644
--- a/include/uapi/linux/input.h
+++ b/include/uapi/linux/input.h
@@ -194,6 +194,8 @@ struct input_keymap_entry {
 #define SYN_CONFIG		1
 #define SYN_MT_REPORT		2
 #define SYN_DROPPED		3
+#define SYN_MAX			0xf
+#define SYN_CNT			(SYN_MAX+1)
 
 /*
  * Keys and buttons
-- 
1.8.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Input: add SYN_MAX and SYN_CNT constants
  2013-08-27 11:23 [PATCH] Input: add SYN_MAX and SYN_CNT constants David Herrmann
@ 2013-08-29  1:06 ` Peter Hutterer
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Hutterer @ 2013-08-29  1:06 UTC (permalink / raw)
  To: David Herrmann; +Cc: linux-input, Dmitry Torokhov

On Tue, Aug 27, 2013 at 01:23:52PM +0200, David Herrmann wrote:
> SYN_* events are special and not enabled via set_bit() for devices. Hence,
> they haven't been really needed, yet. However, user-space can still make
> great use of that for int->string debugging helpers or alike.
> 
> Also, I haven't seen any reason not to define these, so here they are.
> 
> Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
> ---
>  include/uapi/linux/input.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
> index 4649ee3..2fb6fae 100644
> --- a/include/uapi/linux/input.h
> +++ b/include/uapi/linux/input.h
> @@ -194,6 +194,8 @@ struct input_keymap_entry {
>  #define SYN_CONFIG		1
>  #define SYN_MT_REPORT		2
>  #define SYN_DROPPED		3
> +#define SYN_MAX			0xf
> +#define SYN_CNT			(SYN_MAX+1)
>  
>  /*
>   * Keys and buttons
> -- 
> 1.8.4

yes please!

Acked-by: Peter Hutterer <peter.hutterer@who-t.net>

Cheers,
   Peter


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-08-29  1:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-27 11:23 [PATCH] Input: add SYN_MAX and SYN_CNT constants David Herrmann
2013-08-29  1:06 ` Peter Hutterer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).