From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] i2c-hid: explicitly cast parametrs to follow specifiers
Date: Wed, 04 Sep 2013 14:51:14 +0300 [thread overview]
Message-ID: <1378295474.22798.15.camel@smile> (raw)
In-Reply-To: <alpine.LNX.2.00.1309041317030.3684@pobox.suse.cz>
On Wed, 2013-09-04 at 13:17 +0200, Jiri Kosina wrote:
> On Tue, 25 Jun 2013, Andy Shevchenko wrote:
>
> > The vendor and product parameters are defined as __u32, but used as short int.
> > Let's do an explicit casting for them.
>
> Is this fixing any compiler warning you have seen?
It was found by static analyzer.
>
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/hid/i2c-hid/i2c-hid.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> > index 879b0ed..d595f2a 100644
> > --- a/drivers/hid/i2c-hid/i2c-hid.c
> > +++ b/drivers/hid/i2c-hid/i2c-hid.c
> > @@ -1009,7 +1009,7 @@ static int i2c_hid_probe(struct i2c_client *client,
> > hid->product = le16_to_cpu(ihid->hdesc.wProductID);
> >
> > snprintf(hid->name, sizeof(hid->name), "%s %04hX:%04hX",
> > - client->name, hid->vendor, hid->product);
> > + client->name, (short int)hid->vendor, (short int)hid->product);
...and it's probably better to use (unsigned short int) if this patch is
going anywhere.
> >
> > ret = hid_add_device(hid);
> > if (ret) {
> > --
> > 1.8.3.1
> >
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2013-09-04 11:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 12:24 [PATCH] i2c-hid: explicitly cast parametrs to follow specifiers Andy Shevchenko
2013-08-06 11:43 ` Andy Shevchenko
2013-09-04 11:17 ` Jiri Kosina
2013-09-04 11:51 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378295474.22798.15.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).