From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: linux-input@vger.kernel.org, linux-iio@vger.kernel.org
Cc: jc23@cam.ac.uk, jkosina@suse.cz, holler@ahsoftware.de,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: [PATCH 3/3] HID RTC: Open sensor hub open close
Date: Tue, 10 Sep 2013 13:03:52 -0700 [thread overview]
Message-ID: <1378843432-5113-3-git-send-email-srinivas.pandruvada@linux.intel.com> (raw)
In-Reply-To: <1378843432-5113-1-git-send-email-srinivas.pandruvada@linux.intel.com>
Open sensor hub when module is loaded and close when module is removed.
This helps saving power by opening HID transport only when there is an
user.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
drivers/rtc/rtc-hid-sensor-time.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-hid-sensor-time.c b/drivers/rtc/rtc-hid-sensor-time.c
index 7273b01..1fe170c 100644
--- a/drivers/rtc/rtc-hid-sensor-time.c
+++ b/drivers/rtc/rtc-hid-sensor-time.c
@@ -279,15 +279,28 @@ static int hid_time_probe(struct platform_device *pdev)
return ret;
}
+ ret = sensor_hub_device_open(hsdev);
+ if (ret) {
+ dev_err(&pdev->dev, "failed to open sensor hub device!\n");
+ goto err_open;
+ }
+
time_state->rtc = devm_rtc_device_register(&pdev->dev,
"hid-sensor-time", &hid_time_rtc_ops,
THIS_MODULE);
if (IS_ERR(time_state->rtc)) {
dev_err(&pdev->dev, "rtc device register failed!\n");
- return PTR_ERR(time_state->rtc);
+ ret = PTR_ERR(time_state->rtc);
+ goto err_rtc;
}
+ return 0;
+
+err_rtc:
+ sensor_hub_device_close(hsdev);
+err_open:
+ sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_TIME);
return ret;
}
@@ -295,6 +308,7 @@ static int hid_time_remove(struct platform_device *pdev)
{
struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data;
+ sensor_hub_device_close(hsdev);
sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_TIME);
return 0;
--
1.8.3.1
next prev parent reply other threads:[~2013-09-10 20:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 20:03 [PATCH 1/3] HID: Delay opening HID device Srinivas Pandruvada
2013-09-10 20:03 ` [PATCH 2/3] IIO: call sensor hub open close function Srinivas Pandruvada
2013-09-10 20:03 ` Srinivas Pandruvada [this message]
[not found] ` <1378843432-5113-3-git-send-email-srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-09-15 10:18 ` [PATCH 3/3] HID RTC: Open sensor hub open close Jonathan Cameron
[not found] ` <52358980.4030000-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-09-16 13:07 ` [rtc-linux] " Alessandro Zummo
[not found] ` <1378843432-5113-1-git-send-email-srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-09-15 10:15 ` [PATCH 1/3] HID: Delay opening HID device Jonathan Cameron
[not found] ` <523588DE.1000603-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-09-18 16:44 ` Srinivas Pandruvada
-- strict thread matches above, loose matches on Subject: below --
2013-09-18 17:13 Srinivas Pandruvada
[not found] ` <1379524399-16995-1-git-send-email-srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-09-18 17:13 ` [PATCH 3/3] HID RTC: Open sensor hub open close Srinivas Pandruvada
[not found] ` <1379524399-16995-3-git-send-email-srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-10-01 8:42 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378843432-5113-3-git-send-email-srinivas.pandruvada@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=holler@ahsoftware.de \
--cc=jc23@cam.ac.uk \
--cc=jkosina@suse.cz \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).