From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Benjamin Tissoires <benjamin.tissoires@gmail.com>,
Kees Cook <keescook@chromium.org>,
Henrik Rydberg <rydberg@euromail.se>,
Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 00/10] HID: validate report details
Date: Wed, 11 Sep 2013 21:56:49 +0200 [thread overview]
Message-ID: <1378929419-6269-1-git-send-email-benjamin.tissoires@redhat.com> (raw)
Hi guys,
here is the v3 of the CVE fixes.
I have tested the multitouch and logitech-dj part, and the lenovo-tpkbd has been
tested in the bug referenced in patch 10.
Cheers,
Benjamin
Changes since v2:
- fix lenovo-tpkbd report validation
- fix lenovo-tpkbd not releasing the device when the report was not valid
- use generic tests found in previous hid-multitouch patches, so that this will
not happen again
- fix input_report index retrieving in hid-multitouch
Original message from Kees (v2):
These patches introduce a validation function for HID devices that do
direct report value accesses, solving a number of heap smashing flaws.
This version changes to using an field-index-based checker for the new
"hid_validate_values()" which requires callers to loop across fields if
they use more than one field.
Benjamin Tissoires (3):
HID: validate feature and input report details
HID: multitouch: validate indexes details
HID: lenovo-tpkbd: fix leak if tpkbd_probe_tp fails
Kees Cook (7):
HID: provide a helper for validating hid reports
HID: zeroplus: validate output report details
HID: sony: validate HID output report details
HID: steelseries: validate output report details
HID: LG: validate HID output report details
HID: lenovo-tpkbd: validate output report details
HID: logitech-dj: validate output report details
drivers/hid/hid-core.c | 74 +++++++++++++++++++++++++++++++++++++-----
drivers/hid/hid-input.c | 11 ++++++-
drivers/hid/hid-lenovo-tpkbd.c | 25 ++++++++++----
drivers/hid/hid-lg2ff.c | 19 ++---------
drivers/hid/hid-lg3ff.c | 29 ++++-------------
drivers/hid/hid-lg4ff.c | 20 +-----------
drivers/hid/hid-lgff.c | 17 ++--------
drivers/hid/hid-logitech-dj.c | 10 ++++--
drivers/hid/hid-multitouch.c | 26 ++++++++-------
drivers/hid/hid-sony.c | 4 +++
drivers/hid/hid-steelseries.c | 5 +++
drivers/hid/hid-zpff.c | 18 +++-------
include/linux/hid.h | 4 +++
13 files changed, 146 insertions(+), 116 deletions(-)
--
1.8.3.1
next reply other threads:[~2013-09-11 19:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 19:56 Benjamin Tissoires [this message]
2013-09-11 19:56 ` [PATCH v3 01/10] HID: provide a helper for validating hid reports Benjamin Tissoires
2013-09-11 19:56 ` [PATCH v3 02/10] HID: zeroplus: validate output report details Benjamin Tissoires
2013-09-11 19:56 ` [PATCH v3 03/10] HID: sony: validate HID " Benjamin Tissoires
2013-09-12 12:39 ` Josh Boyer
2013-09-12 14:11 ` Benjamin Tissoires
2013-09-11 19:56 ` [PATCH v3 04/10] HID: steelseries: validate " Benjamin Tissoires
2013-09-11 19:56 ` [PATCH v3 05/10] HID: LG: validate HID " Benjamin Tissoires
2013-09-11 19:56 ` [PATCH v3 06/10] HID: lenovo-tpkbd: validate " Benjamin Tissoires
2013-09-11 20:06 ` Kees Cook
2013-09-11 20:08 ` Benjamin Tissoires
2013-09-11 19:56 ` [PATCH v3 07/10] HID: logitech-dj: " Benjamin Tissoires
2013-09-11 19:56 ` [PATCH v3 08/10] HID: validate feature and input " Benjamin Tissoires
2013-09-11 20:08 ` Kees Cook
2013-09-11 19:56 ` [PATCH v3 09/10] HID: multitouch: validate indexes details Benjamin Tissoires
2013-09-11 20:09 ` Kees Cook
2013-09-11 19:56 ` [PATCH v3 10/10] HID: lenovo-tpkbd: fix leak if tpkbd_probe_tp fails Benjamin Tissoires
2013-09-11 20:11 ` [PATCH v3 00/10] HID: validate report details Kees Cook
2013-09-13 13:15 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378929419-6269-1-git-send-email-benjamin.tissoires@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=benjamin.tissoires@gmail.com \
--cc=jkosina@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).