From: Ryan Mallon <rmallon@gmail.com>
To: dmitry.torokhov@gmail.com, rydberg@euromail.se
Cc: carl@ok-labs.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, Ryan Mallon <rmallon@gmail.com>
Subject: [PATCH 1/2] input: Return the number of bytes written so far on evdev write failure
Date: Wed, 18 Sep 2013 08:55:43 +1000 [thread overview]
Message-ID: <1379458544-6508-1-git-send-email-rmallon@gmail.com> (raw)
If input_event_from_user() fails in evdev write() and at least one
event has been written successfully then return the number of bytes
written. If no events have been written, then the EFAULT error is
returned.
Signed-off-by: Ryan Mallon <rmallon@gmail.com>
---
drivers/input/evdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
index d2b34fb..b0dec2ba 100644
--- a/drivers/input/evdev.c
+++ b/drivers/input/evdev.c
@@ -437,7 +437,8 @@ static ssize_t evdev_write(struct file *file, const char __user *buffer,
while (retval + input_event_size() <= count) {
if (input_event_from_user(buffer + retval, &event)) {
- retval = -EFAULT;
+ if (retval == 0)
+ retval = -EFAULT;
goto out;
}
retval += input_event_size();
--
1.7.9.7
next reply other threads:[~2013-09-17 22:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 22:55 Ryan Mallon [this message]
2013-09-17 22:55 ` [PATCH 2/2] uinput: Support injecting multiple events in one write() call Ryan Mallon
2013-09-18 19:48 ` Dmitry Torokhov
2013-09-18 21:36 ` Ryan Mallon
2013-09-18 22:15 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379458544-6508-1-git-send-email-rmallon@gmail.com \
--to=rmallon@gmail.com \
--cc=carl@ok-labs.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).