* [PATCH] SOUND/SPI: Fix "clk_round_rate" undefined reference error.
@ 2013-10-08 10:40 Majunath Goudar
2013-10-22 22:53 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Majunath Goudar @ 2013-10-08 10:40 UTC (permalink / raw)
To: linux-arm-kernel
Cc: nataraja.km, Majunath Goudar, Dmitry Torokhov, linux-kernel,
linux-input
This patch adds a COMMON_CLK dependency to configure the
SND_AT73C213 for Atmel AT73C213 DAC driver. Without this patch,
build system can lead to build failure. This was observed during
randconfig testing, in which SND_AT73C213 was enabled w/o COMMON_CLK
being enabled. leading to the following error:
sound/built-in.o: In function `snd_at73c213_probe':
:(.text+0x328c4): undefined reference to `clk_round_rate'
make: *** [vmlinux] Error 1
Signed-off-by: Manjunath Goudar <csmanjuvijay@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
sound/spi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/spi/Kconfig b/sound/spi/Kconfig
index e6485be..798d1ee 100644
--- a/sound/spi/Kconfig
+++ b/sound/spi/Kconfig
@@ -11,7 +11,7 @@ if SND_SPI
config SND_AT73C213
tristate "Atmel AT73C213 DAC driver"
- depends on ATMEL_SSC
+ depends on ATMEL_SSC && COMMON_CLK
select SND_PCM
help
Say Y here if you want to use the Atmel AT73C213 external DAC. This
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] SOUND/SPI: Fix "clk_round_rate" undefined reference error.
2013-10-08 10:40 [PATCH] SOUND/SPI: Fix "clk_round_rate" undefined reference error Majunath Goudar
@ 2013-10-22 22:53 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2013-10-22 22:53 UTC (permalink / raw)
To: Majunath Goudar; +Cc: linux-arm-kernel, nataraja.km, linux-input, linux-kernel
Hi Majunath,
On Tue, Oct 08, 2013 at 04:10:33PM +0530, Majunath Goudar wrote:
> This patch adds a COMMON_CLK dependency to configure the
> SND_AT73C213 for Atmel AT73C213 DAC driver. Without this patch,
> build system can lead to build failure. This was observed during
> randconfig testing, in which SND_AT73C213 was enabled w/o COMMON_CLK
> being enabled. leading to the following error:
>
> sound/built-in.o: In function `snd_at73c213_probe':
> :(.text+0x328c4): undefined reference to `clk_round_rate'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Manjunath Goudar <csmanjuvijay@gmail.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: linux-input@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> sound/spi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/spi/Kconfig b/sound/spi/Kconfig
> index e6485be..798d1ee 100644
> --- a/sound/spi/Kconfig
> +++ b/sound/spi/Kconfig
> @@ -11,7 +11,7 @@ if SND_SPI
>
> config SND_AT73C213
> tristate "Atmel AT73C213 DAC driver"
> - depends on ATMEL_SSC
> + depends on ATMEL_SSC && COMMON_CLK
I do not see clk_round_rate() being protected by CONFIG_COMMON_CLK so it
looks to me that ATMEL_SSC is at fault here.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-22 22:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-08 10:40 [PATCH] SOUND/SPI: Fix "clk_round_rate" undefined reference error Majunath Goudar
2013-10-22 22:53 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).