From: Joe Perches <joe@perches.com>
To: "Geyslan G. Bem" <geyslan@gmail.com>
Cc: dmitry.torokhov@gmail.com, dudl@cypress.com, kamal@canonical.com,
mario_limonciello@dell.com, git@status.e4ward.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-br@googlegroups.com
Subject: Re: [PATCH v2] drivers: input: mouse: Remove useless casting in cypress_ps2.c
Date: Wed, 16 Oct 2013 15:39:58 -0700 [thread overview]
Message-ID: <1381963198.22110.73.camel@joe-AO722> (raw)
In-Reply-To: <1381962675-26876-1-git-send-email-geyslan@gmail.com>
On Wed, 2013-10-16 at 19:31 -0300, Geyslan G. Bem wrote:
> Get rid of unnecessary (void *) casting in 'cypress_init' function.
[]
> diff --git a/drivers/input/mouse/cypress_ps2.c b/drivers/input/mouse/cypress_ps2.c
[]
> @@ -680,7 +680,7 @@ int cypress_init(struct psmouse *psmouse)
> struct cytp_data *cytp;
>
> cytp = (struct cytp_data *)kzalloc(sizeof(struct cytp_data), GFP_KERNEL);
> - psmouse->private = (void *)cytp;
> + psmouse->private = cytp;
If you are going to remove useless casts, please
also remove the unnecessary kzalloc cast too.
next prev parent reply other threads:[~2013-10-16 22:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 22:31 [PATCH v2] drivers: input: mouse: Remove useless casting in cypress_ps2.c Geyslan G. Bem
2013-10-16 22:39 ` Joe Perches [this message]
2013-10-16 22:53 ` Geyslan Gregório Bem
2013-10-17 17:19 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381963198.22110.73.camel@joe-AO722 \
--to=joe@perches.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dudl@cypress.com \
--cc=geyslan@gmail.com \
--cc=git@status.e4ward.com \
--cc=kamal@canonical.com \
--cc=kernel-br@googlegroups.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario_limonciello@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).