From: Bibek Basu <bbasu@nvidia.com>
To: benjamin.tissoires@gmail.com
Cc: jkosina@suse.cz, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, Bibek Basu <bbasu@nvidia.com>
Subject: [PATCH] HID: i2c-hid: Stop querying for init reports
Date: Mon, 21 Oct 2013 09:59:13 +0530 [thread overview]
Message-ID: <1382329753-15589-1-git-send-email-bbasu@nvidia.com> (raw)
According to specifications, HID over I2C devices
are not bound to respond to query for INPUT
REPORTS. Thus dropping the call during init
as many devices does not respond causing error
messages during boot.
Signed-off-by: Bibek Basu <bbasu@nvidia.com>
---
drivers/hid/i2c-hid/i2c-hid.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
index fd7ce37..ae48d18 100644
--- a/drivers/hid/i2c-hid/i2c-hid.c
+++ b/drivers/hid/i2c-hid/i2c-hid.c
@@ -455,10 +455,6 @@ static void i2c_hid_init_reports(struct hid_device *hid)
}
list_for_each_entry(report,
- &hid->report_enum[HID_INPUT_REPORT].report_list, list)
- i2c_hid_init_report(report, inbuf, ihid->bufsize);
-
- list_for_each_entry(report,
&hid->report_enum[HID_FEATURE_REPORT].report_list, list)
i2c_hid_init_report(report, inbuf, ihid->bufsize);
--
1.8.1.5
next reply other threads:[~2013-10-21 4:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 4:29 Bibek Basu [this message]
2013-10-30 13:24 ` [PATCH] HID: i2c-hid: Stop querying for init reports Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2013-10-15 8:28 Bibek Basu
2013-10-17 17:57 ` Benjamin Tissoires
2013-10-21 4:23 ` Bibek Basu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382329753-15589-1-git-send-email-bbasu@nvidia.com \
--to=bbasu@nvidia.com \
--cc=benjamin.tissoires@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox