From: Simon Wood <simon@mungewell.org>
To: linux-input@vger.kernel.org
Cc: "Jiri Kosina" <jkosina@suse.cz>,
linux-kernel@vger.kernel.org, simon@mungewell.org,
"Elias Vanderstuyft" <elias.vds@gmail.com>,
"Michal Malý" <madcatxster@prifuk.cz>
Subject: [PATCH 3/5] HID:hid-lg4ff: ensure ConstantForce is disabled when set to 0
Date: Wed, 6 Nov 2013 12:30:42 -0700 [thread overview]
Message-ID: <1383766244-2336-3-git-send-email-simon@mungewell.org> (raw)
In-Reply-To: <1383766244-2336-1-git-send-email-simon@mungewell.org>
When 'Constant Force' is set to 0 it is not turned off completely,
the wheel feels 'heavy'. This patch issues the '13 00..' command
to ensure that the force in slot 1 (the Constant Force) is
deactivated.
Reported-by: Elias Vanderstuyft <elias.vds@gmail.com>
Signed-off-by: Simon Wood <simon@mungewell.org>
---
drivers/hid/hid-lg4ff.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
index 49f6cc0..5d140b7 100644
--- a/drivers/hid/hid-lg4ff.c
+++ b/drivers/hid/hid-lg4ff.c
@@ -196,6 +196,21 @@ static int hid_lg4ff_play(struct input_dev *dev, void *data, struct ff_effect *e
case FF_CONSTANT:
x = effect->u.ramp.start_level + 0x80; /* 0x80 is no force */
CLAMP(x);
+
+ if (x == 0x80) {
+ /* De-activate force in slot-1*/
+ value[0] = 0x13;
+ value[1] = 0x00;
+ value[2] = 0x00;
+ value[3] = 0x00;
+ value[4] = 0x00;
+ value[5] = 0x00;
+ value[6] = 0x00;
+
+ hid_hw_request(hid, report, HID_REQ_SET_REPORT);
+ return 0;
+ }
+
value[0] = 0x11; /* Slot 1 */
value[1] = 0x08;
value[2] = x;
--
1.8.1.2
next prev parent reply other threads:[~2013-11-06 19:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 19:30 [PATCH 1/5] HID:hid-lg4ff: Scale autocentering force properly on Logitech wheel Simon Wood
2013-11-06 19:30 ` [PATCH 2/5] HID:hid-lg4ff: Switch autocentering off when strength is set to zero Simon Wood
2013-11-06 19:30 ` Simon Wood [this message]
2013-11-06 19:30 ` [PATCH 4/5] HID:hid-lg4ff: Initialize device properties before we touch autocentering Simon Wood
2013-11-06 19:30 ` [PATCH 5/5] HID:hid-lg4ff: Correct Auto-center strength for wheels other than MOMO and MOMO2 Simon Wood
2013-11-08 13:14 ` [PATCH 1/5] HID:hid-lg4ff: Scale autocentering force properly on Logitech wheel Jiri Kosina
2013-11-08 15:54 ` simon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383766244-2336-3-git-send-email-simon@mungewell.org \
--to=simon@mungewell.org \
--cc=elias.vds@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madcatxster@prifuk.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).