linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	dmitry.torokhov@gmail.com, rob.herring@calxeda.com,
	Pawel.Moll@arm.com, swarren@wwwdotorg.org,
	ijc+devicetree@hellion.org.uk, bcousson@baylibre.com,
	Tony Lindgren <tony@atomide.com>,
	devicetree@vger.kernel.org,
	Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
	linux-input@vger.kernel.org, Felipe Balbi <balbi@ti.com>
Subject: [PATCH] input: touchscreen: ti_am335x_tsc: warn about incorrect spelling
Date: Mon, 18 Nov 2013 09:29:01 -0600	[thread overview]
Message-ID: <1384788541-16338-1-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <20131118114029.GD30853@e106331-lin.cambridge.arm.com>

In the hopes that people run new kernels on
their devices, let's add a warning message
asking users to have their DTS file fixed.

The goal is that by Linux 4.0 we will be
able to remove support for the bogus version
of our touchscreen's DTS.

Suggested-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
---

Here you go, I've added your Suggested-by Mark,
if you wish I can remove or change to something
else.

cheers

 drivers/input/touchscreen/ti_am335x_tsc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
index b61df9d..91302cd 100644
--- a/drivers/input/touchscreen/ti_am335x_tsc.c
+++ b/drivers/input/touchscreen/ti_am335x_tsc.c
@@ -354,9 +354,12 @@ static int titsc_parse_dt(struct platform_device *pdev,
 	 */
 	err = of_property_read_u32(node, "ti,coordinate-readouts",
 			&ts_dev->coordinate_readouts);
-	if (err < 0)
+	if (err < 0) {
+		dev_warn(&pdev->dev, "please use 'ti,coordinate-readouts' instead\n");
 		err = of_property_read_u32(node, "ti,coordiante-readouts",
 				&ts_dev->coordinate_readouts);
+	}
+
 	if (err < 0)
 		return err;
 
-- 
1.8.4.GIT


  reply	other threads:[~2013-11-18 15:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21 20:13 [PATCH 0/2] arm: am335x: am335x evm sk: add touchscreen DT node Felipe Balbi
2013-10-21 20:13 ` [PATCH 1/2] input: touchscreen: fix spelling mistake in TSC/ADC DT binding Felipe Balbi
2013-10-22  8:42   ` Sebastian Andrzej Siewior
2013-10-22 12:02     ` Felipe Balbi
2013-11-14 11:19       ` Mark Rutland
2013-11-14 15:54         ` Felipe Balbi
2013-11-15 15:55           ` Mark Rutland
2013-11-15 17:53             ` Felipe Balbi
2013-11-18 11:40               ` Mark Rutland
2013-11-18 15:29                 ` Felipe Balbi [this message]
2013-11-18 15:35                   ` [PATCH] input: touchscreen: ti_am335x_tsc: warn about incorrect spelling Mark Rutland
2014-06-14  0:23                   ` Felipe Balbi
2014-06-15  7:16                     ` Dmitry Torokhov
2014-06-15 15:55                       ` Felipe Balbi
2013-10-21 20:13 ` [PATCH 2/2] arm: dts: am335x sk: add touchscreen support Felipe Balbi
     [not found] ` <1382386404-6659-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2013-11-11  7:59   ` [PATCH 0/2] arm: am335x: am335x evm sk: add touchscreen DT node Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384788541-16338-1-git-send-email-balbi@ti.com \
    --to=balbi@ti.com \
    --cc=Pawel.Moll@arm.com \
    --cc=bcousson@baylibre.com \
    --cc=bigeasy@linutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=swarren@wwwdotorg.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).