From: Bastien Nocera <hadess@hadess.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
linux-input@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>
Subject: Re: [RFC][PATCH] Input: define keys for WWAN and SES
Date: Thu, 28 Nov 2013 15:14:25 +0100 [thread overview]
Message-ID: <1385648065.17991.11.camel@nuvo> (raw)
In-Reply-To: <CACna6ry8gE28ke=yNgO1OC_ahzcN0EStfpDhFoFL9+N_yddpHg@mail.gmail.com>
On Thu, 2013-11-28 at 15:06 +0100, Rafał Miłecki wrote:
> 2013/11/28 Bastien Nocera <hadess@hadess.net>:
> > On Thu, 2013-11-28 at 13:32 +0100, Rafał Miłecki wrote:
> >> I'm just not sure about possible scenarios. I imagined end-user
> >> pressing SES button router and SES button on a device and complaining
> >> it's not working (because of SES being interpreted as WPS).
> >>
> >> If you guys think we should just use WPS for the SES button, I'm OK with that.
> >
> > Isn't the fact that it returns WPS or SES an implementation detail?
> >
> > Is WPS vs. SES just a software choice, or a hardware one? If it's a
> > hardware one, you'd expect to have other ways to discover whether SES or
> > WPS was requested (because that's the one supported by the hardware). If
> > it's a software choice, then you'd expect the button to one or the other
> > based on the software stack.
> >
> > Or are both possible at the same time, and there are devices with both
> > buttons?
> >
> > Seems that adding a note that other similar "pairing" methods for Wi-Fi
> > could be triggered when the button is used, in input.h would be enough.
>
> I think it's just a software thing (some EAP messages probably).
>
> Thanks for your comments!
>
> What about KEY_WWAN. Does it make sense to add it?
If there are "keys" with that sort of label, it would make sense to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-11-28 14:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 11:48 [RFC][PATCH] Input: define keys for WWAN and SES Rafał Miłecki
2013-11-28 12:06 ` Hauke Mehrtens
2013-11-28 12:32 ` Rafał Miłecki
2013-11-28 13:01 ` Bastien Nocera
2013-11-28 14:06 ` Rafał Miłecki
2013-11-28 14:14 ` Bastien Nocera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385648065.17991.11.camel@nuvo \
--to=hadess@hadess.net \
--cc=hauke@hauke-m.de \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).