* [PATCH] Input: define KEY_WWAN for Wireless WAN
@ 2013-11-28 18:42 Rafał Miłecki
2013-12-04 17:10 ` Dmitry Torokhov
2013-12-10 10:29 ` [PATCH V2] " Rafał Miłecki
0 siblings, 2 replies; 6+ messages in thread
From: Rafał Miłecki @ 2013-11-28 18:42 UTC (permalink / raw)
To: linux-input, Jiri Kosina; +Cc: Hauke Mehrtens, Rafał Miłecki
Some devices with support for mobile networks may have buttons for
enabling/disabling such connection. An example can be Linksys router
54G3G.
We already have KEY_BLUETOOTH, KEY_WLAN and KEY_UWB so it makes sense
to add KEY_WWAN as well.
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
include/uapi/linux/input.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
index 4649ee3..173d77f 100644
--- a/include/uapi/linux/input.h
+++ b/include/uapi/linux/input.h
@@ -749,6 +749,8 @@ struct input_keymap_entry {
#define BTN_TRIGGER_HAPPY39 0x2e6
#define BTN_TRIGGER_HAPPY40 0x2e7
+#define KEY_WWAN 0x2e8 /* Wireless WAN (LTE, UMTS, GSM, etc.) */
+
/* We avoid low common keys in module aliases so they don't get huge. */
#define KEY_MIN_INTERESTING KEY_MUTE
#define KEY_MAX 0x2ff
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Input: define KEY_WWAN for Wireless WAN
2013-11-28 18:42 [PATCH] Input: define KEY_WWAN for Wireless WAN Rafał Miłecki
@ 2013-12-04 17:10 ` Dmitry Torokhov
2013-12-04 18:00 ` Rafał Miłecki
2013-12-10 10:29 ` [PATCH V2] " Rafał Miłecki
1 sibling, 1 reply; 6+ messages in thread
From: Dmitry Torokhov @ 2013-12-04 17:10 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: linux-input, Jiri Kosina, Hauke Mehrtens
Hi Rafal,
On Thu, Nov 28, 2013 at 07:42:53PM +0100, Rafał Miłecki wrote:
> Some devices with support for mobile networks may have buttons for
> enabling/disabling such connection. An example can be Linksys router
> 54G3G.
> We already have KEY_BLUETOOTH, KEY_WLAN and KEY_UWB so it makes sense
> to add KEY_WWAN as well.
Isn't WiMAX an implementation of WWAN? Maybe instead of adding a new
keycode we should use KEY_WIMAX code and alias KEY_WIMAX to KEY_WWAN to
preserve ABI?
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Input: define KEY_WWAN for Wireless WAN
2013-12-04 17:10 ` Dmitry Torokhov
@ 2013-12-04 18:00 ` Rafał Miłecki
0 siblings, 0 replies; 6+ messages in thread
From: Rafał Miłecki @ 2013-12-04 18:00 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, Jiri Kosina, Hauke Mehrtens
2013/12/4 Dmitry Torokhov <dmitry.torokhov@gmail.com>:
> Hi Rafal,
>
> On Thu, Nov 28, 2013 at 07:42:53PM +0100, Rafał Miłecki wrote:
>> Some devices with support for mobile networks may have buttons for
>> enabling/disabling such connection. An example can be Linksys router
>> 54G3G.
>> We already have KEY_BLUETOOTH, KEY_WLAN and KEY_UWB so it makes sense
>> to add KEY_WWAN as well.
>
> Isn't WiMAX an implementation of WWAN? Maybe instead of adding a new
> keycode we should use KEY_WIMAX code and alias KEY_WIMAX to KEY_WWAN to
> preserve ABI?
I didn't think about it but if WiMAX is indeed kind of WWAN, it makes
a perfect sense to me!
--
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2] Input: define KEY_WWAN for Wireless WAN
2013-11-28 18:42 [PATCH] Input: define KEY_WWAN for Wireless WAN Rafał Miłecki
2013-12-04 17:10 ` Dmitry Torokhov
@ 2013-12-10 10:29 ` Rafał Miłecki
2013-12-10 19:36 ` Jiri Kosina
1 sibling, 1 reply; 6+ messages in thread
From: Rafał Miłecki @ 2013-12-10 10:29 UTC (permalink / raw)
To: linux-input, Jiri Kosina; +Cc: Hauke Mehrtens, Rafał Miłecki
Some devices with support for mobile networks may have buttons for
enabling/disabling such connection. An example can be Linksys router
54G3G.
We already have KEY_BLUETOOTH, KEY_WLAN and KEY_UWB so it makes sense
to add KEY_WWAN as well.
As we already have KEY_WIMAX, use it's value for KEY_WWAN and make it an
alias.
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
V2: Re-use 246 value for WWAN and make WIMAX an aliast to WWAN
---
include/uapi/linux/input.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
index a372627..7c69941 100644
--- a/include/uapi/linux/input.h
+++ b/include/uapi/linux/input.h
@@ -464,7 +464,8 @@ struct input_keymap_entry {
#define KEY_BRIGHTNESS_ZERO 244 /* brightness off, use ambient */
#define KEY_DISPLAY_OFF 245 /* display device to off state */
-#define KEY_WIMAX 246
+#define KEY_WWAN 246 /* Wireless WAN (LTE, UMTS, GSM, etc.) */
+#define KEY_WIMAX KEY_WWAN
#define KEY_RFKILL 247 /* Key that controls all radios */
#define KEY_MICMUTE 248 /* Mute / unmute the microphone */
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V2] Input: define KEY_WWAN for Wireless WAN
2013-12-10 10:29 ` [PATCH V2] " Rafał Miłecki
@ 2013-12-10 19:36 ` Jiri Kosina
2013-12-16 5:02 ` Dmitry Torokhov
0 siblings, 1 reply; 6+ messages in thread
From: Jiri Kosina @ 2013-12-10 19:36 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: linux-input, Hauke Mehrtens, Dmitry Torokhov
On Tue, 10 Dec 2013, Rafał Miłecki wrote:
> Some devices with support for mobile networks may have buttons for
> enabling/disabling such connection. An example can be Linksys router
> 54G3G.
> We already have KEY_BLUETOOTH, KEY_WLAN and KEY_UWB so it makes sense
> to add KEY_WWAN as well.
> As we already have KEY_WIMAX, use it's value for KEY_WWAN and make it an
> alias.
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> V2: Re-use 246 value for WWAN and make WIMAX an aliast to WWAN
> ---
> include/uapi/linux/input.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
> index a372627..7c69941 100644
> --- a/include/uapi/linux/input.h
> +++ b/include/uapi/linux/input.h
> @@ -464,7 +464,8 @@ struct input_keymap_entry {
> #define KEY_BRIGHTNESS_ZERO 244 /* brightness off, use ambient */
> #define KEY_DISPLAY_OFF 245 /* display device to off state */
>
> -#define KEY_WIMAX 246
> +#define KEY_WWAN 246 /* Wireless WAN (LTE, UMTS, GSM, etc.) */
> +#define KEY_WIMAX KEY_WWAN
> #define KEY_RFKILL 247 /* Key that controls all radios */
>
> #define KEY_MICMUTE 248 /* Mute / unmute the microphone */
Adding Dmitry to CC
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH V2] Input: define KEY_WWAN for Wireless WAN
2013-12-10 19:36 ` Jiri Kosina
@ 2013-12-16 5:02 ` Dmitry Torokhov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2013-12-16 5:02 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Rafał Miłecki, linux-input, Hauke Mehrtens
On Tue, Dec 10, 2013 at 08:36:41PM +0100, Jiri Kosina wrote:
> On Tue, 10 Dec 2013, Rafał Miłecki wrote:
>
> > Some devices with support for mobile networks may have buttons for
> > enabling/disabling such connection. An example can be Linksys router
> > 54G3G.
> > We already have KEY_BLUETOOTH, KEY_WLAN and KEY_UWB so it makes sense
> > to add KEY_WWAN as well.
> > As we already have KEY_WIMAX, use it's value for KEY_WWAN and make it an
> > alias.
> >
> > Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> > ---
> > V2: Re-use 246 value for WWAN and make WIMAX an aliast to WWAN
> > ---
> > include/uapi/linux/input.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
> > index a372627..7c69941 100644
> > --- a/include/uapi/linux/input.h
> > +++ b/include/uapi/linux/input.h
> > @@ -464,7 +464,8 @@ struct input_keymap_entry {
> > #define KEY_BRIGHTNESS_ZERO 244 /* brightness off, use ambient */
> > #define KEY_DISPLAY_OFF 245 /* display device to off state */
> >
> > -#define KEY_WIMAX 246
> > +#define KEY_WWAN 246 /* Wireless WAN (LTE, UMTS, GSM, etc.) */
> > +#define KEY_WIMAX KEY_WWAN
> > #define KEY_RFKILL 247 /* Key that controls all radios */
> >
> > #define KEY_MICMUTE 248 /* Mute / unmute the microphone */
>
> Adding Dmitry to CC
Applied, thank you.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-12-16 5:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-28 18:42 [PATCH] Input: define KEY_WWAN for Wireless WAN Rafał Miłecki
2013-12-04 17:10 ` Dmitry Torokhov
2013-12-04 18:00 ` Rafał Miłecki
2013-12-10 10:29 ` [PATCH V2] " Rafał Miłecki
2013-12-10 19:36 ` Jiri Kosina
2013-12-16 5:02 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).