* [PATCH] drivers/input/misc/adxl34x: Fix bug in definition of ADXL346_2D_ORIENT
@ 2013-12-09 11:35 michael.hennerich
2013-12-10 6:14 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: michael.hennerich @ 2013-12-09 11:35 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, Michael Hennerich
From: Michael Hennerich <michael.hennerich@analog.com>
Coverity report pointet out by Dmitry
Reported-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
---
drivers/input/misc/adxl34x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c
index 0735de3..1cb1da2 100644
--- a/drivers/input/misc/adxl34x.c
+++ b/drivers/input/misc/adxl34x.c
@@ -158,7 +158,7 @@
/* ORIENT ADXL346 only */
#define ADXL346_2D_VALID (1 << 6)
-#define ADXL346_2D_ORIENT(x) (((x) & 0x3) >> 4)
+#define ADXL346_2D_ORIENT(x) (((x) & 0x30) >> 4)
#define ADXL346_3D_VALID (1 << 3)
#define ADXL346_3D_ORIENT(x) ((x) & 0x7)
#define ADXL346_2D_PORTRAIT_POS 0 /* +X */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/input/misc/adxl34x: Fix bug in definition of ADXL346_2D_ORIENT
2013-12-09 11:35 [PATCH] drivers/input/misc/adxl34x: Fix bug in definition of ADXL346_2D_ORIENT michael.hennerich
@ 2013-12-10 6:14 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2013-12-10 6:14 UTC (permalink / raw)
To: michael.hennerich; +Cc: linux-input
On Mon, Dec 09, 2013 at 12:35:10PM +0100, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> Coverity report pointet out by Dmitry
>
> Reported-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Applied, thank you.
> ---
> drivers/input/misc/adxl34x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c
> index 0735de3..1cb1da2 100644
> --- a/drivers/input/misc/adxl34x.c
> +++ b/drivers/input/misc/adxl34x.c
> @@ -158,7 +158,7 @@
>
> /* ORIENT ADXL346 only */
> #define ADXL346_2D_VALID (1 << 6)
> -#define ADXL346_2D_ORIENT(x) (((x) & 0x3) >> 4)
> +#define ADXL346_2D_ORIENT(x) (((x) & 0x30) >> 4)
> #define ADXL346_3D_VALID (1 << 3)
> #define ADXL346_3D_ORIENT(x) ((x) & 0x7)
> #define ADXL346_2D_PORTRAIT_POS 0 /* +X */
> --
> 1.7.9.5
>
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-10 6:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-09 11:35 [PATCH] drivers/input/misc/adxl34x: Fix bug in definition of ADXL346_2D_ORIENT michael.hennerich
2013-12-10 6:14 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).