linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Felipe F. Tonello" <eu@felipetonello.com>
To: linux-kernel@vger.kernel.org
Cc: linux-input@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Sachin Kamat <sachin.kamat@linaro.org>,
	Heiko Abraham <abrahamh@web.de>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	"Felipe F. Tonello" <eu@felipetonello.com>
Subject: [PATCH] input: egalax: Send touch end event when is about to suspend
Date: Tue, 10 Dec 2013 16:03:16 -0800	[thread overview]
Message-ID: <1386720196-5821-1-git-send-email-eu@felipetonello.com> (raw)

From: "Felipe F. Tonello" <eu@felipetonello.com>

This is useful to report for users of this device that don't know anything
about the suspension of the device. So users will receive a touch end event
when the device is about to suspend, making it more user friendly.

One example of users is the X Server with the evdev input driver. This patch
make sure that the X server will propagate a touch end event to its windows.

Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
 drivers/input/touchscreen/egalax_ts.c | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/egalax_ts.c b/drivers/input/touchscreen/egalax_ts.c
index 054d225..1f21f0d 100644
--- a/drivers/input/touchscreen/egalax_ts.c
+++ b/drivers/input/touchscreen/egalax_ts.c
@@ -63,6 +63,7 @@
 struct egalax_ts {
 	struct i2c_client		*client;
 	struct input_dev		*input_dev;
+	bool					ids_in_use[MAX_SUPPORT_POINTS];
 };
 
 static irqreturn_t egalax_ts_interrupt(int irq, void *dev_id)
@@ -117,6 +118,8 @@ static irqreturn_t egalax_ts_interrupt(int irq, void *dev_id)
 	input_mt_report_pointer_emulation(input_dev, true);
 	input_sync(input_dev);
 
+	ts->ids_in_use[id] = down;
+
 	return IRQ_HANDLED;
 }
 
@@ -247,9 +250,22 @@ static int egalax_ts_suspend(struct device *dev)
 		0x3, 0x6, 0xa, 0x3, 0x36, 0x3f, 0x2, 0, 0, 0
 	};
 	struct i2c_client *client = to_i2c_client(dev);
-	int ret;
+	struct egalax_ts *ts = i2c_get_clientdata(client);
+	int ret, id;
 
 	ret = i2c_master_send(client, suspend_cmd, MAX_I2C_DATA_LEN);
+
+	/* We send a touch end event (for the ids in use) if the egalax module is
+	   about to be turned off. */
+	for (id = 0; id < MAX_SUPPORT_POINTS; ++id) {
+		if (ts->ids_in_use[id]) {
+			input_mt_slot(ts->input_dev, id);
+			input_mt_report_slot_state(ts->input_dev, MT_TOOL_FINGER, false);
+			input_mt_report_pointer_emulation(ts->input_dev, true);
+			input_sync(ts->input_dev);
+		}
+	}
+
 	return ret > 0 ? 0 : ret;
 }
 
-- 
1.8.3.1


             reply	other threads:[~2013-12-11  0:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-11  0:03 Felipe F. Tonello [this message]
2013-12-15 10:40 ` [PATCH] input: egalax: Send touch end event when is about to suspend Dmitry Torokhov
2013-12-16 23:45   ` Felipe Ferreri Tonello
2013-12-30  0:36     ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386720196-5821-1-git-send-email-eu@felipetonello.com \
    --to=eu@felipetonello.com \
    --cc=abrahamh@web.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).