From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Heiny Subject: [PATCH] input synaptics-rmi4: Bug fixes to ATTN GPIO handling. Date: Mon, 16 Dec 2013 19:45:06 -0800 Message-ID: <1387251906-23530-1-git-send-email-cheiny@synaptics.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from us-mx2.synaptics.com ([192.147.44.131]:50519 "EHLO us-mx2.synaptics.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751169Ab3LQDpL (ORCPT ); Mon, 16 Dec 2013 22:45:11 -0500 Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Linux Input , Christopher Heiny , Andrew Duggan , Vincent Huang , Vivian Ly , Daniel Rosenberg , Jean Delvare , Joerie de Gram , Linus Walleij , Benjamin Tissoires This patch fixes two bugs in handling of the RMI4 attention line GPIO. 1) in enable_sensor(), make sure the attn_gpio is defined before attempting to get its value. 2) in rmi_driver_probe(), declare the name of the attn_gpio, then request the attn_gpio before attempting to export it. As an added bonus, the code relating to the export is tidied up. Signed-off-by: Christopher Heiny Cc: Dmitry Torokhov Cc: Benjamin Tissoires --- This patch implements changes to the synaptics-rmi4 branch of Dmitry's input tree. The base for the patch is commit e0c5aec5e6144ae8391d164e2dc659f8ef2b2ba7. drivers/input/rmi4/rmi_driver.c | 37 ++++++++++++++++++++++--------------- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c index a30c7d3..030e8d5 100644 --- a/drivers/input/rmi4/rmi_driver.c +++ b/drivers/input/rmi4/rmi_driver.c @@ -169,7 +169,7 @@ static int enable_sensor(struct rmi_device *rmi_dev) data->enabled = true; - if (!pdata->level_triggered && + if (pdata->attn_gpio && !pdata->level_triggered && gpio_get_value(pdata->attn_gpio) == pdata->attn_polarity) retval = process_interrupt_requests(rmi_dev); @@ -807,6 +807,9 @@ static int rmi_driver_remove(struct device *dev) return 0; } + +static const char *GPIO_LABEL = "attn"; + static int rmi_driver_probe(struct device *dev) { struct rmi_driver *rmi_driver; @@ -959,20 +962,24 @@ static int rmi_driver_probe(struct device *dev) } if (IS_ENABLED(CONFIG_RMI4_DEV) && pdata->attn_gpio) { - retval = gpio_export(pdata->attn_gpio, false); - if (retval) { - dev_warn(dev, "WARNING: Failed to export ATTN gpio!\n"); - retval = 0; - } else { - retval = gpio_export_link(dev, - "attn", pdata->attn_gpio); - if (retval) { - dev_warn(dev, - "WARNING: Failed to symlink ATTN gpio!\n"); - retval = 0; - } else { - dev_info(dev, "Exported ATTN GPIO %d.", - pdata->attn_gpio); + retval = gpio_request(pdata->attn_gpio, GPIO_LABEL); + if (retval) + dev_warn(dev, "WARNING: Failed to request ATTN gpio %d, code: %d.\n", + pdata->attn_gpio, retval); + else { + retval = gpio_export(pdata->attn_gpio, false); + if (retval) + dev_warn(dev, "WARNING: Failed to export ATTN %d, code: %d.\n", + pdata->attn_gpio, retval); + else { + retval = gpio_export_link(dev, "attn", + pdata->attn_gpio); + if (retval) + dev_warn(dev, + "WARNING: Failed to symlink ATTN gpio!\n"); + else + dev_info(dev, "Exported ATTN GPIO %d.", + pdata->attn_gpio); } } }