From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
Shawn Guo <shawn.guo@linaro.org>,
Silvio F <silvio.fricke@gmail.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Jingoo Han <jg1.han@samsung.com>,
Fugang Duan <B38611@freescale.com>,
Sachin Kamat <sachin.kamat@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Cc: "Lothar Waßmann" <LW@KARO-electronics.de>
Subject: [PATCHv3 4/4] Input: edt-ft5x06 adjust reset delays according to datasheet
Date: Fri, 17 Jan 2014 13:28:38 +0100 [thread overview]
Message-ID: <1389961718-8130-5-git-send-email-LW@KARO-electronics.de> (raw)
In-Reply-To: <1389961718-8130-1-git-send-email-LW@KARO-electronics.de>
The FT5x06 datasheet specifies a minimum reset width of 5ms and a
delay between deassertion of reset and start of reporting of 300ms.
Adjust the delays to conform to the datasheet.
With the original delays I sometimes experienced communication
timeouts when initializing the controller.
Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
drivers/input/touchscreen/edt-ft5x06.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index ec6b3e5..bd42845 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -653,9 +653,9 @@ static int edt_ft5x06_ts_reset(struct i2c_client *client,
return error;
}
- mdelay(50);
+ mdelay(5);
gpio_set_value(tsdata->reset_pin, 1);
- mdelay(100);
+ msleep(300);
}
return 0;
--
1.7.2.5
prev parent reply other threads:[~2014-01-17 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 12:28 Input: edt-ft5x06: Add DT support Lothar Waßmann
2014-01-17 12:28 ` [PATCHv3 1/4] DT: Add vendor prefix for Emerging Display Technologies Lothar Waßmann
2014-01-17 22:18 ` Rob Herring
2014-01-17 12:28 ` [PATCHv3 2/4] Input: edt_ft5x06: use devm_* functions where appropriate Lothar Waßmann
2014-01-17 12:28 ` [PATCHv3 3/4] Input: edt-ft5x06: Add DT support Lothar Waßmann
2014-01-17 12:28 ` Lothar Waßmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389961718-8130-5-git-send-email-LW@KARO-electronics.de \
--to=lw@karo-electronics.de \
--cc=B38611@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jg1.han@samsung.com \
--cc=jic23@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=shawn.guo@linaro.org \
--cc=silvio.fricke@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox