linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Raghu Gandham <raghu.gandham@imgtec.com>
To: dmitry.torokhov@gmail.com, aaro.koskinen@iki.fi,
	linux-input@vger.kernel.org, linux-mips@linux-mips.org,
	linux-kernel@vger.kernel.org
Cc: Raghu Gandham <raghu.gandham@imgtec.com>
Subject: [PATCH] Input: i8042-io - Exclude mips platforms when allocating/deallocating IO regions.
Date: Sat, 25 Jan 2014 11:01:54 -0800	[thread overview]
Message-ID: <1390676514-30880-1-git-send-email-raghu.gandham@imgtec.com> (raw)

The standard IO regions are already reserved by the platform code on most MIPS
devices(malta, cobalt, sni). The Commit 197a1e96c8be5b6005145af3a4c0e45e2d651444
("Input: i8042-io - fix up region handling on MIPS") introduced a bug on these
MIPS platforms causing i8042 driver to fail when trying to reserve IO ports.
Prior to the above mentioned commit request_region is skipped on MIPS but
release_region is called.

This patch reverts commit 197a1e96c8be5b6005145af3a4c0e45e2d651444 and also
avoids calling release_region for MIPS.

Signed-off-by: Raghu Gandham <raghu.gandham@imgtec.com>
Reviewed-by: Steven J. Hill <Steven.Hill@imgtec.com>
---
 drivers/input/serio/i8042-io.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/serio/i8042-io.h b/drivers/input/serio/i8042-io.h
index a5eed2a..a09bb72 100644
--- a/drivers/input/serio/i8042-io.h
+++ b/drivers/input/serio/i8042-io.h
@@ -76,7 +76,7 @@ static inline int i8042_platform_init(void)
 	if (check_legacy_ioport(I8042_DATA_REG))
 		return -ENODEV;
 #endif
-#if !defined(__sh__) && !defined(__alpha__)
+#if !defined(__sh__) && !defined(__alpha__) && !defined(__mips__)
 	if (!request_region(I8042_DATA_REG, 16, "i8042"))
 		return -EBUSY;
 #endif
@@ -87,7 +87,7 @@ static inline int i8042_platform_init(void)
 
 static inline void i8042_platform_exit(void)
 {
-#if !defined(__sh__) && !defined(__alpha__)
+#if !defined(__sh__) && !defined(__alpha__) && !defined(__mips__)
 	release_region(I8042_DATA_REG, 16);
 #endif
 }
-- 
1.8.5.2

             reply	other threads:[~2014-01-25 19:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-25 19:01 Raghu Gandham [this message]
2014-01-26 21:49 ` [PATCH] Input: i8042-io - Exclude mips platforms when allocating/deallocating IO regions Dmitry Torokhov
2014-01-27  0:32   ` Raghu Gandham
2014-01-27  6:56     ` Dmitry Torokhov
2014-01-27 20:24       ` Aaro Koskinen
2014-01-28  6:25         ` Raghu Gandham
2014-03-19 20:49           ` Ralf Baechle
2014-03-19 23:44             ` Aaro Koskinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390676514-30880-1-git-send-email-raghu.gandham@imgtec.com \
    --to=raghu.gandham@imgtec.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).