* [PATCH] input: sirfsoc-onkey - set the capability of reporting KEY_POWER
@ 2014-02-25 13:36 Barry Song
2014-03-27 7:35 ` Barry Song
0 siblings, 1 reply; 3+ messages in thread
From: Barry Song @ 2014-02-25 13:36 UTC (permalink / raw)
To: dmitry.torokhov, linux-input; +Cc: workgroup.linux, Xianglong Du, Barry Song
From: Xianglong Du <Xianglong.Du@csr.com>
commit a1a7521064428fc1cf8 moved to report EV_KEY event(KEY_POWER) instead of
reporting EV_PWR event(KEY_SUSPEND), but it didn't enable the capability, so
the KEY_POWER will not be reported to userspace by input core. this patch fixes
the issue.
Signed-off-by: Xianglong Du <Xianglong.Du@csr.com>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
---
drivers/input/misc/sirfsoc-onkey.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/misc/sirfsoc-onkey.c b/drivers/input/misc/sirfsoc-onkey.c
index 4d66c72..e4104f9 100644
--- a/drivers/input/misc/sirfsoc-onkey.c
+++ b/drivers/input/misc/sirfsoc-onkey.c
@@ -136,6 +136,7 @@ static int sirfsoc_pwrc_probe(struct platform_device *pdev)
pwrcdrv->input->name = "sirfsoc pwrckey";
pwrcdrv->input->phys = "pwrc/input0";
pwrcdrv->input->evbit[0] = BIT_MASK(EV_KEY);
+ input_set_capability(pwrcdrv->input, EV_KEY, KEY_POWER);
INIT_DELAYED_WORK(&pwrcdrv->work, sirfsoc_pwrc_report_event);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] input: sirfsoc-onkey - set the capability of reporting KEY_POWER
2014-02-25 13:36 [PATCH] input: sirfsoc-onkey - set the capability of reporting KEY_POWER Barry Song
@ 2014-03-27 7:35 ` Barry Song
2014-03-28 7:39 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Barry Song @ 2014-03-27 7:35 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input@vger.kernel.org
Cc: DL-SHA-WorkGroupLinux, Xianglong Du, Barry Song
2014-02-25 21:36 GMT+08:00 Barry Song <21cnbao@gmail.com>:
> From: Xianglong Du <Xianglong.Du@csr.com>
>
> commit a1a7521064428fc1cf8 moved to report EV_KEY event(KEY_POWER) instead of
> reporting EV_PWR event(KEY_SUSPEND), but it didn't enable the capability, so
> the KEY_POWER will not be reported to userspace by input core. this patch fixes
> the issue.
>
> Signed-off-by: Xianglong Du <Xianglong.Du@csr.com>
> Signed-off-by: Barry Song <Baohua.Song@csr.com>
> ---
Dmitry, i guess you missed this one, this one should be in 3.15,
otherwise, onkey is broken.
> drivers/input/misc/sirfsoc-onkey.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/misc/sirfsoc-onkey.c b/drivers/input/misc/sirfsoc-onkey.c
> index 4d66c72..e4104f9 100644
> --- a/drivers/input/misc/sirfsoc-onkey.c
> +++ b/drivers/input/misc/sirfsoc-onkey.c
> @@ -136,6 +136,7 @@ static int sirfsoc_pwrc_probe(struct platform_device *pdev)
> pwrcdrv->input->name = "sirfsoc pwrckey";
> pwrcdrv->input->phys = "pwrc/input0";
> pwrcdrv->input->evbit[0] = BIT_MASK(EV_KEY);
> + input_set_capability(pwrcdrv->input, EV_KEY, KEY_POWER);
>
> INIT_DELAYED_WORK(&pwrcdrv->work, sirfsoc_pwrc_report_event);
>
> --
> 1.7.9.5
>
-barry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] input: sirfsoc-onkey - set the capability of reporting KEY_POWER
2014-03-27 7:35 ` Barry Song
@ 2014-03-28 7:39 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2014-03-28 7:39 UTC (permalink / raw)
To: Barry Song
Cc: linux-input@vger.kernel.org, DL-SHA-WorkGroupLinux, Xianglong Du,
Barry Song
On Thu, Mar 27, 2014 at 03:35:46PM +0800, Barry Song wrote:
> 2014-02-25 21:36 GMT+08:00 Barry Song <21cnbao@gmail.com>:
> > From: Xianglong Du <Xianglong.Du@csr.com>
> >
> > commit a1a7521064428fc1cf8 moved to report EV_KEY event(KEY_POWER) instead of
> > reporting EV_PWR event(KEY_SUSPEND), but it didn't enable the capability, so
> > the KEY_POWER will not be reported to userspace by input core. this patch fixes
> > the issue.
> >
> > Signed-off-by: Xianglong Du <Xianglong.Du@csr.com>
> > Signed-off-by: Barry Song <Baohua.Song@csr.com>
> > ---
>
> Dmitry, i guess you missed this one, this one should be in 3.15,
> otherwise, onkey is broken.
Applied, thank you.
>
>
> > drivers/input/misc/sirfsoc-onkey.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/input/misc/sirfsoc-onkey.c b/drivers/input/misc/sirfsoc-onkey.c
> > index 4d66c72..e4104f9 100644
> > --- a/drivers/input/misc/sirfsoc-onkey.c
> > +++ b/drivers/input/misc/sirfsoc-onkey.c
> > @@ -136,6 +136,7 @@ static int sirfsoc_pwrc_probe(struct platform_device *pdev)
> > pwrcdrv->input->name = "sirfsoc pwrckey";
> > pwrcdrv->input->phys = "pwrc/input0";
> > pwrcdrv->input->evbit[0] = BIT_MASK(EV_KEY);
> > + input_set_capability(pwrcdrv->input, EV_KEY, KEY_POWER);
> >
> > INIT_DELAYED_WORK(&pwrcdrv->work, sirfsoc_pwrc_report_event);
> >
> > --
> > 1.7.9.5
> >
>
> -barry
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-28 7:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-25 13:36 [PATCH] input: sirfsoc-onkey - set the capability of reporting KEY_POWER Barry Song
2014-03-27 7:35 ` Barry Song
2014-03-28 7:39 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).