linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adam Jackson <ajax@redhat.com>
To: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Peter Jones <pjones@redhat.com>
Subject: [PATCH] i8042: Don't print an error message just because there's no chip
Date: Tue, 25 Feb 2014 10:47:07 -0500	[thread overview]
Message-ID: <1393343227-13092-1-git-send-email-ajax@redhat.com> (raw)
In-Reply-To: <1222713404-1097-1-git-send-email-ajax@redhat.com>

From: Peter Jones <pjones@redhat.com>

Some systems, such as EFI-based Apple systems, won't necessarily have an
i8042 to initialize. We shouldn't be printing an error message in this
case, since not detecting the chip is the correct behavior.

v2: Downgrade to pr_notice instead of pr_err.

Signed-off-by: Adam Jackson <ajax@redhat.com>
---
 drivers/input/serio/i8042.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
index 020053f..05c6285 100644
--- a/drivers/input/serio/i8042.c
+++ b/drivers/input/serio/i8042.c
@@ -855,7 +855,7 @@ static int __init i8042_check_aux(void)
 static int i8042_controller_check(void)
 {
 	if (i8042_flush()) {
-		pr_err("No controller found\n");
+		pr_notice("No controller found\n");
 		return -ENODEV;
 	}
 
-- 
1.8.5.3


       reply	other threads:[~2014-02-25 15:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1222713404-1097-1-git-send-email-ajax@redhat.com>
2014-02-25 15:47 ` Adam Jackson [this message]
2014-02-25 16:06   ` [PATCH] i8042: Don't print an error message just because there's no chip Josh Boyer
2014-06-03 13:53     ` Adam Jackson
2014-06-03 14:00       ` Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393343227-13092-1-git-send-email-ajax@redhat.com \
    --to=ajax@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).