* [PATCH] i8042: Don't print an error message just because there's no chip [not found] <1222713404-1097-1-git-send-email-ajax@redhat.com> @ 2014-02-25 15:47 ` Adam Jackson 2014-02-25 16:06 ` Josh Boyer 0 siblings, 1 reply; 4+ messages in thread From: Adam Jackson @ 2014-02-25 15:47 UTC (permalink / raw) To: linux-input; +Cc: linux-kernel, Peter Jones From: Peter Jones <pjones@redhat.com> Some systems, such as EFI-based Apple systems, won't necessarily have an i8042 to initialize. We shouldn't be printing an error message in this case, since not detecting the chip is the correct behavior. v2: Downgrade to pr_notice instead of pr_err. Signed-off-by: Adam Jackson <ajax@redhat.com> --- drivers/input/serio/i8042.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c index 020053f..05c6285 100644 --- a/drivers/input/serio/i8042.c +++ b/drivers/input/serio/i8042.c @@ -855,7 +855,7 @@ static int __init i8042_check_aux(void) static int i8042_controller_check(void) { if (i8042_flush()) { - pr_err("No controller found\n"); + pr_notice("No controller found\n"); return -ENODEV; } -- 1.8.5.3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] i8042: Don't print an error message just because there's no chip 2014-02-25 15:47 ` [PATCH] i8042: Don't print an error message just because there's no chip Adam Jackson @ 2014-02-25 16:06 ` Josh Boyer 2014-06-03 13:53 ` Adam Jackson 0 siblings, 1 reply; 4+ messages in thread From: Josh Boyer @ 2014-02-25 16:06 UTC (permalink / raw) To: Adam Jackson; +Cc: linux-input, Linux-Kernel@Vger. Kernel. Org, Peter Jones On Tue, Feb 25, 2014 at 10:47 AM, Adam Jackson <ajax@redhat.com> wrote: > From: Peter Jones <pjones@redhat.com> > > Some systems, such as EFI-based Apple systems, won't necessarily have an > i8042 to initialize. We shouldn't be printing an error message in this > case, since not detecting the chip is the correct behavior. > > v2: Downgrade to pr_notice instead of pr_err. > > Signed-off-by: Adam Jackson <ajax@redhat.com> Reviewed-by: Josh Boyer <jwboyer@fedoraproject.org> > --- > drivers/input/serio/i8042.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c > index 020053f..05c6285 100644 > --- a/drivers/input/serio/i8042.c > +++ b/drivers/input/serio/i8042.c > @@ -855,7 +855,7 @@ static int __init i8042_check_aux(void) > static int i8042_controller_check(void) > { > if (i8042_flush()) { > - pr_err("No controller found\n"); > + pr_notice("No controller found\n"); > return -ENODEV; > } > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] i8042: Don't print an error message just because there's no chip 2014-02-25 16:06 ` Josh Boyer @ 2014-06-03 13:53 ` Adam Jackson 2014-06-03 14:00 ` Benjamin Tissoires 0 siblings, 1 reply; 4+ messages in thread From: Adam Jackson @ 2014-06-03 13:53 UTC (permalink / raw) To: Josh Boyer; +Cc: linux-input, Linux-Kernel@Vger. Kernel. Org, Peter Jones On Tue, 2014-02-25 at 11:06 -0500, Josh Boyer wrote: > On Tue, Feb 25, 2014 at 10:47 AM, Adam Jackson <ajax@redhat.com> wrote: > > From: Peter Jones <pjones@redhat.com> > > > > Some systems, such as EFI-based Apple systems, won't necessarily have an > > i8042 to initialize. We shouldn't be printing an error message in this > > case, since not detecting the chip is the correct behavior. > > > > v2: Downgrade to pr_notice instead of pr_err. > > > > Signed-off-by: Adam Jackson <ajax@redhat.com> > > Reviewed-by: Josh Boyer <jwboyer@fedoraproject.org> Ping? This patch or something like it has been pending since 2008 [1], would be nice to see it merged before it's old enough to start first grade. [1] - https://lkml.org/lkml/2008/9/29/248 - ajax ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] i8042: Don't print an error message just because there's no chip 2014-06-03 13:53 ` Adam Jackson @ 2014-06-03 14:00 ` Benjamin Tissoires 0 siblings, 0 replies; 4+ messages in thread From: Benjamin Tissoires @ 2014-06-03 14:00 UTC (permalink / raw) To: Adam Jackson Cc: Josh Boyer, linux-input, Linux-Kernel@Vger. Kernel. Org, Peter Jones, Dmitry Torokhov On Tue, Jun 3, 2014 at 9:53 AM, Adam Jackson <ajax@redhat.com> wrote: > On Tue, 2014-02-25 at 11:06 -0500, Josh Boyer wrote: >> On Tue, Feb 25, 2014 at 10:47 AM, Adam Jackson <ajax@redhat.com> wrote: >> > From: Peter Jones <pjones@redhat.com> >> > >> > Some systems, such as EFI-based Apple systems, won't necessarily have an >> > i8042 to initialize. We shouldn't be printing an error message in this >> > case, since not detecting the chip is the correct behavior. >> > >> > v2: Downgrade to pr_notice instead of pr_err. >> > >> > Signed-off-by: Adam Jackson <ajax@redhat.com> >> >> Reviewed-by: Josh Boyer <jwboyer@fedoraproject.org> > > Ping? This patch or something like it has been pending since 2008 [1], > would be nice to see it merged before it's old enough to start first > grade. > > [1] - https://lkml.org/lkml/2008/9/29/248 > Hey Ajax, regarding the input stuff, adding the maintainers always help. So adding Dmitry in CC. BTW, the patch looks good enough: Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cheers, Benjamin ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-06-03 14:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1222713404-1097-1-git-send-email-ajax@redhat.com>
2014-02-25 15:47 ` [PATCH] i8042: Don't print an error message just because there's no chip Adam Jackson
2014-02-25 16:06 ` Josh Boyer
2014-06-03 13:53 ` Adam Jackson
2014-06-03 14:00 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).