From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Benjamin Tissoires <benjamin.tissoires@gmail.com>,
Henrik Rydberg <rydberg@euromail.se>,
Jiri Kosina <jkosina@suse.cz>, Stephane Chatty <chatty@enac.fr>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] HID: multitouch cleanups and support for fancy devices
Date: Fri, 28 Feb 2014 11:41:22 -0500 [thread overview]
Message-ID: <1393605685-17025-1-git-send-email-benjamin.tissoires@redhat.com> (raw)
Hi guys,
Ok, this patch series is not very consistent and could have been split in two...
Anyway, here is some work for hid-multitouch:
- the first patch is mainly a way for us to reduce the work load regarding hid-mt
when device makers ask for an inclusion in the kernel.
Also, I have been notified that a Quanta 3008 was not working, and it occurs
that this particular device has a special handling in hid-mt. Of course, the
hardware maker reused the same VID/PID, but changed the protocol.
So yes, I am in favour of killing all unneeded special cases.
I checked all the devices I was able to test, and this leaves us a bunch of
devices which, I am sure, could be removed too (all the ones following
MT_CLS_NSMU should be in this case). So, if anyone else wants to join me in
this crusade, I'd be glad to receive patches.
- the second and third patch are the v2 of the series I sent back in December
2013 ([PATCH 0/3] Change in handling different input device in hid-multitouch).
Henrik made valuable comments, and I did not had the time to look at it and to
figure out how to address them. Now I got a different look at this work, and
I think I addressed the issues (no more function pointers, yeah!)
Happy reviewing.
Cheers,
Benjamin
PS: it might be Spring coming, but I am definitively trying to reduce the total
lines of code in the HID subsystem...
Benjamin Tissoires (3):
HID: multitouch: remove default behaviors
HID: multitouch: remove pen special handling
HID: multitouch: add support of other generic collections in hid-mt
drivers/hid/hid-ids.h | 3 +
drivers/hid/hid-multitouch.c | 270 +++++++++++++++----------------------------
include/linux/hid.h | 3 +
3 files changed, 101 insertions(+), 175 deletions(-)
--
1.8.5.3
next reply other threads:[~2014-02-28 16:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 16:41 Benjamin Tissoires [this message]
2014-02-28 16:41 ` [PATCH 1/3] HID: multitouch: remove registered devices with default behavior Benjamin Tissoires
2014-02-28 16:41 ` [PATCH 2/3] HID: multitouch: remove pen special handling Benjamin Tissoires
2014-02-28 16:41 ` [PATCH 3/3] HID: multitouch: add support of other generic collections in hid-mt Benjamin Tissoires
2014-03-05 13:31 ` [PATCH 0/3] HID: multitouch cleanups and support for fancy devices Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393605685-17025-1-git-send-email-benjamin.tissoires@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=benjamin.tissoires@gmail.com \
--cc=chatty@enac.fr \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).