* [PATCH v1.01] input synaptics-rmi4: rmi_driver.c storage fix
@ 2014-03-06 1:11 Christopher Heiny
0 siblings, 0 replies; only message in thread
From: Christopher Heiny @ 2014-03-06 1:11 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Linux Input, Christopher Heiny, Andrew Duggan, Vincent Huang,
Vivian Ly, Daniel Rosenberg, Linus Walleij, Benjamin Tissoires,
David Herrmann, Jiri Kosina
Do not use kfree() on storage allocated with devm_kzalloc(),
eliminating kernel panics on device removal.
I'm not sure how this eluded all the patching that's been going on over
the past few weeks, but somehow it did. v1.01 - fix brain hiccup in
the commit message.
Reported-by: Courtney Cavin <courtney.cavin@sonymobile.com>
Reported-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reported-by: Andrew Duggan <aduggan@synaptics.com>
Signed-off-by: Christopher Heiny <cheiny@synaptics.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Linux Walleij <linus.walleij@linaro.org>
Cc: David Herrmann <dh.herrmann@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>
---
drivers/input/rmi4/rmi_driver.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
index 4406a7f..3552ffb 100644
--- a/drivers/input/rmi4/rmi_driver.c
+++ b/drivers/input/rmi4/rmi_driver.c
@@ -743,7 +743,6 @@ static int rmi_driver_remove(struct device *dev)
gpio_free(pdata->attn_gpio);
kfree(data->irq_status);
- kfree(data);
return 0;
}
@@ -942,7 +941,6 @@ err_destroy_functions:
err_free_mem:
if (data->gpio_held)
gpio_free(pdata->attn_gpio);
- kfree(data);
return retval < 0 ? retval : 0;
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-03-06 1:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-06 1:11 [PATCH v1.01] input synaptics-rmi4: rmi_driver.c storage fix Christopher Heiny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).