* [PATCH] Add sensor hub quirk for ThinkPad Helix
@ 2014-04-03 20:27 Stephen Chandler Paul
2014-04-03 20:39 ` Srinivas Pandruvada
2014-04-03 20:54 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Chandler Paul @ 2014-04-03 20:27 UTC (permalink / raw)
To: Jiri Kosina, linux-input, linux-kernel
Cc: Benjamin Tissoires, Srinivas Pandruvada, Adam Williamson
Just like some of the other laptops/tablets on the market with ultrabook
sensors, the ThinkPad Helix's sensor hub requires a special quirk in
order for it to power on properly. Without it the sensors are detected
by the kernel and set up as usual, but they won't output any data. This
will also fix the sensors on any other laptops with the same model of
sensor hub.
Signed-off-by: Stephen Chandler Paul <thatslyude@gmail.com>
---
drivers/hid/hid-ids.h | 3 ++-
drivers/hid/hid-sensor-hub.c | 7 +++++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index bd22126..3312f1b5 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -455,7 +455,8 @@
#define USB_VENDOR_ID_INTEL_0 0x8086
#define USB_VENDOR_ID_INTEL_1 0x8087
-#define USB_DEVICE_ID_INTEL_HID_SENSOR 0x09fa
+#define USB_DEVICE_ID_INTEL_HID_SENSOR_0 0x09fa
+#define USB_DEVICE_ID_INTEL_HID_SENSOR_1 0x0a04
#define USB_VENDOR_ID_STM_0 0x0483
#define USB_DEVICE_ID_STM_HID_SENSOR 0x91d1
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index 5182031..af8244b 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c
@@ -697,10 +697,13 @@ static void sensor_hub_remove(struct hid_device *hdev)
static const struct hid_device_id sensor_hub_devices[] = {
{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_INTEL_0,
- USB_DEVICE_ID_INTEL_HID_SENSOR),
+ USB_DEVICE_ID_INTEL_HID_SENSOR_0),
.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_INTEL_1,
- USB_DEVICE_ID_INTEL_HID_SENSOR),
+ USB_DEVICE_ID_INTEL_HID_SENSOR_0),
+ .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
+ { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_INTEL_1,
+ USB_DEVICE_ID_INTEL_HID_SENSOR_1),
.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_STM_0,
USB_DEVICE_ID_STM_HID_SENSOR),
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Add sensor hub quirk for ThinkPad Helix
2014-04-03 20:27 [PATCH] Add sensor hub quirk for ThinkPad Helix Stephen Chandler Paul
@ 2014-04-03 20:39 ` Srinivas Pandruvada
2014-04-03 20:54 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Srinivas Pandruvada @ 2014-04-03 20:39 UTC (permalink / raw)
To: Stephen Chandler Paul, Jiri Kosina, linux-input, linux-kernel
Cc: Benjamin Tissoires, Srinivas Pandruvada, Adam Williamson
On 04/03/2014 01:27 PM, Stephen Chandler Paul wrote:
> Just like some of the other laptops/tablets on the market with ultrabook
> sensors, the ThinkPad Helix's sensor hub requires a special quirk in
> order for it to power on properly. Without it the sensors are detected
> by the kernel and set up as usual, but they won't output any data. This
> will also fix the sensors on any other laptops with the same model of
> sensor hub.
>
> Signed-off-by: Stephen Chandler Paul <thatslyude@gmail.com>
> ---
> drivers/hid/hid-ids.h | 3 ++-
> drivers/hid/hid-sensor-hub.c | 7 +++++--
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index bd22126..3312f1b5 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -455,7 +455,8 @@
>
> #define USB_VENDOR_ID_INTEL_0 0x8086
> #define USB_VENDOR_ID_INTEL_1 0x8087
> -#define USB_DEVICE_ID_INTEL_HID_SENSOR 0x09fa
> +#define USB_DEVICE_ID_INTEL_HID_SENSOR_0 0x09fa
> +#define USB_DEVICE_ID_INTEL_HID_SENSOR_1 0x0a04
>
> #define USB_VENDOR_ID_STM_0 0x0483
> #define USB_DEVICE_ID_STM_HID_SENSOR 0x91d1
> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
> index 5182031..af8244b 100644
> --- a/drivers/hid/hid-sensor-hub.c
> +++ b/drivers/hid/hid-sensor-hub.c
> @@ -697,10 +697,13 @@ static void sensor_hub_remove(struct hid_device *hdev)
>
> static const struct hid_device_id sensor_hub_devices[] = {
> { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_INTEL_0,
> - USB_DEVICE_ID_INTEL_HID_SENSOR),
> + USB_DEVICE_ID_INTEL_HID_SENSOR_0),
> .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
> { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_INTEL_1,
> - USB_DEVICE_ID_INTEL_HID_SENSOR),
> + USB_DEVICE_ID_INTEL_HID_SENSOR_0),
> + .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
> + { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_INTEL_1,
> + USB_DEVICE_ID_INTEL_HID_SENSOR_1),
> .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
> { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_STM_0,
> USB_DEVICE_ID_STM_HID_SENSOR),
Acked-by: Srinivas Pandruvada<srinivas.pandruvada@linux.intel.com>
Thanks,
Srinivas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Add sensor hub quirk for ThinkPad Helix
2014-04-03 20:27 [PATCH] Add sensor hub quirk for ThinkPad Helix Stephen Chandler Paul
2014-04-03 20:39 ` Srinivas Pandruvada
@ 2014-04-03 20:54 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2014-04-03 20:54 UTC (permalink / raw)
To: Stephen Chandler Paul
Cc: linux-input, linux-kernel, Benjamin Tissoires,
Srinivas Pandruvada, Adam Williamson
On Thu, 3 Apr 2014, Stephen Chandler Paul wrote:
> Just like some of the other laptops/tablets on the market with ultrabook
> sensors, the ThinkPad Helix's sensor hub requires a special quirk in
> order for it to power on properly. Without it the sensors are detected
> by the kernel and set up as usual, but they won't output any data. This
> will also fix the sensors on any other laptops with the same model of
> sensor hub.
>
> Signed-off-by: Stephen Chandler Paul <thatslyude@gmail.com>
Queued for 3.15, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-03 20:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-03 20:27 [PATCH] Add sensor hub quirk for ThinkPad Helix Stephen Chandler Paul
2014-04-03 20:39 ` Srinivas Pandruvada
2014-04-03 20:54 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).