From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Andrew Duggan <aduggan@synaptics.com>,
Christopher Heiny <cheiny@synaptics.com>,
Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] HID: rmi: do not stop the device at the end of probe
Date: Wed, 9 Apr 2014 11:01:34 -0400 [thread overview]
Message-ID: <1397055694-6312-1-git-send-email-benjamin.tissoires@redhat.com> (raw)
Well, this is embarrassing, if the device is stopped at the end of probe,
we get into big troubles (it even oopses my kernel).
This was a leftover of an attempt to be smart when sending the patch,
I deeply apologies.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
Hi Jiri,
well, first thanks for having integrating hid-rmi in your for 3.16 branch.
While backporting it to 3.13 so Fedora can get it, I noticed a tiny difference
(besides formatting) between the version I submitted and the one I asked people
to test...
...facepalm.
Cheers,
Benjamin
drivers/hid/hid-rmi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index 699d631..7da9509 100644
--- a/drivers/hid/hid-rmi.c
+++ b/drivers/hid/hid-rmi.c
@@ -848,7 +848,6 @@ static int rmi_probe(struct hid_device *hdev, const struct hid_device_id *id)
return -EIO;
}
- hid_hw_stop(hdev);
return 0;
}
--
1.9.0
next reply other threads:[~2014-04-09 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 15:01 Benjamin Tissoires [this message]
2014-04-09 15:14 ` [PATCH] HID: rmi: do not stop the device at the end of probe Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397055694-6312-1-git-send-email-benjamin.tissoires@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=aduggan@synaptics.com \
--cc=cheiny@synaptics.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).