* [PATCH] HID: rmi: do not stop the device at the end of probe
@ 2014-04-09 15:01 Benjamin Tissoires
2014-04-09 15:14 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Tissoires @ 2014-04-09 15:01 UTC (permalink / raw)
To: Andrew Duggan, Christopher Heiny, Jiri Kosina, linux-input,
linux-kernel
Well, this is embarrassing, if the device is stopped at the end of probe,
we get into big troubles (it even oopses my kernel).
This was a leftover of an attempt to be smart when sending the patch,
I deeply apologies.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
Hi Jiri,
well, first thanks for having integrating hid-rmi in your for 3.16 branch.
While backporting it to 3.13 so Fedora can get it, I noticed a tiny difference
(besides formatting) between the version I submitted and the one I asked people
to test...
...facepalm.
Cheers,
Benjamin
drivers/hid/hid-rmi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index 699d631..7da9509 100644
--- a/drivers/hid/hid-rmi.c
+++ b/drivers/hid/hid-rmi.c
@@ -848,7 +848,6 @@ static int rmi_probe(struct hid_device *hdev, const struct hid_device_id *id)
return -EIO;
}
- hid_hw_stop(hdev);
return 0;
}
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: rmi: do not stop the device at the end of probe
2014-04-09 15:01 [PATCH] HID: rmi: do not stop the device at the end of probe Benjamin Tissoires
@ 2014-04-09 15:14 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2014-04-09 15:14 UTC (permalink / raw)
To: Benjamin Tissoires
Cc: Andrew Duggan, Christopher Heiny, linux-input, linux-kernel
On Wed, 9 Apr 2014, Benjamin Tissoires wrote:
> Well, this is embarrassing, if the device is stopped at the end of probe,
> we get into big troubles (it even oopses my kernel).
>
> This was a leftover of an attempt to be smart when sending the patch,
> I deeply apologies.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
>
> Hi Jiri,
>
> well, first thanks for having integrating hid-rmi in your for 3.16 branch.
>
> While backporting it to 3.13 so Fedora can get it, I noticed a tiny difference
> (besides formatting) between the version I submitted and the one I asked people
> to test...
>
> ...facepalm.
Well, I missed that as well when reviewing it. Good catch, now queued on
top of previous one. Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-09 15:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-09 15:01 [PATCH] HID: rmi: do not stop the device at the end of probe Benjamin Tissoires
2014-04-09 15:14 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).