From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v3 1/3] Input: gpio_keys - use dev instead of pdev in gpio_keys_setup_key() Date: Mon, 28 Apr 2014 12:42:39 +0300 Message-ID: <1398678159.11914.285.camel@smile.fi.intel.com> References: <1398442937-15309-1-git-send-email-andriy.shevchenko@linux.intel.com> <1398442937-15309-2-git-send-email-andriy.shevchenko@linux.intel.com> <20140425212112.GA16783@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com ([134.134.136.20]:43433 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754195AbaD1Jmm (ORCPT ); Mon, 28 Apr 2014 05:42:42 -0400 In-Reply-To: <20140425212112.GA16783@core.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Linus Walleij , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, 2014-04-25 at 14:21 -0700, Dmitry Torokhov wrote: > On Fri, Apr 25, 2014 at 07:22:15PM +0300, Andy Shevchenko wrote: > > The platform device is not used in gpio_keys_setup_key(). This patch > > substitutes it by struct device. > > And the benefit of this is...? Probably no benefit for now. Let's drop it for good. -- Andy Shevchenko Intel Finland Oy