* [PATCH] HID: rmi: fix duplicated argument to && or ||
@ 2014-05-13 19:15 Benjamin Tissoires
2014-05-13 19:18 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Tissoires @ 2014-05-13 19:15 UTC (permalink / raw)
To: Jiri Kosina, Dan Carpenter, Andrew Duggan, linux-input,
linux-kernel
This resulted from an unfortunate copy/paste.
Detected automagically by kbuild.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/hid/hid-rmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index 7da9509..8a2ad19 100644
--- a/drivers/hid/hid-rmi.c
+++ b/drivers/hid/hid-rmi.c
@@ -754,9 +754,9 @@ static void rmi_input_configured(struct hid_device *hdev, struct hid_input *hi)
input_set_abs_params(input, ABS_MT_POSITION_X, 1, data->max_x, 0, 0);
input_set_abs_params(input, ABS_MT_POSITION_Y, 1, data->max_y, 0, 0);
- if (data->x_size_mm && data->x_size_mm) {
+ if (data->x_size_mm && data->y_size_mm) {
res_x = (data->max_x - 1) / data->x_size_mm;
- res_y = (data->max_y - 1) / data->x_size_mm;
+ res_y = (data->max_y - 1) / data->y_size_mm;
input_abs_set_res(input, ABS_MT_POSITION_X, res_x);
input_abs_set_res(input, ABS_MT_POSITION_Y, res_y);
--
1.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: rmi: fix duplicated argument to && or ||
2014-05-13 19:15 [PATCH] HID: rmi: fix duplicated argument to && or || Benjamin Tissoires
@ 2014-05-13 19:18 ` Jiri Kosina
2014-05-13 19:23 ` Benjamin Tissoires
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Kosina @ 2014-05-13 19:18 UTC (permalink / raw)
To: Benjamin Tissoires
Cc: Dan Carpenter, Andrew Duggan, linux-input, linux-kernel
On Tue, 13 May 2014, Benjamin Tissoires wrote:
> This resulted from an unfortunate copy/paste.
>
> Detected automagically by kbuild.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
I have already fixed this in the tree after seeing Dan's email.
Thanks, good catch!
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: rmi: fix duplicated argument to && or ||
2014-05-13 19:18 ` Jiri Kosina
@ 2014-05-13 19:23 ` Benjamin Tissoires
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2014-05-13 19:23 UTC (permalink / raw)
To: Jiri Kosina
Cc: Benjamin Tissoires, Dan Carpenter, Andrew Duggan, linux-input,
linux-kernel@vger.kernel.org
On Tue, May 13, 2014 at 3:18 PM, Jiri Kosina <jkosina@suse.cz> wrote:
> On Tue, 13 May 2014, Benjamin Tissoires wrote:
>
>> This resulted from an unfortunate copy/paste.
>>
>> Detected automagically by kbuild.
>>
>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>
> I have already fixed this in the tree after seeing Dan's email.
>
> Thanks, good catch!
Hey, thanks to you! :)
Cheers,
Benjamin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-13 19:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-13 19:15 [PATCH] HID: rmi: fix duplicated argument to && or || Benjamin Tissoires
2014-05-13 19:18 ` Jiri Kosina
2014-05-13 19:23 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).