linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Ping Cheng <pinglinux@gmail.com>,
	Jason Gerecke <killertofu@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxwacom-devel@lists.sourceforge.net
Subject: [PATCH 0/5] Input - wacom: split out pad data from the stylus input device
Date: Mon, 23 Jun 2014 16:57:14 -0400	[thread overview]
Message-ID: <1403557039-1487-1-git-send-email-benjamin.tissoires@redhat.com> (raw)

Hi,

This patch series aims at simplifying the handling of Wacom devices from the user
space point of view. As mentioned in the commit message from 1/5, the pad data
are interleaved into the stylus input for some devices, and into the touch input
for others.

It doesn't makes real sense to interleave pad with stylus because pad data are
not linked to the absolute position of a stylus (or its presence). It is a
device by itself which should have its own input node.

It will also help the handling of the old Wacom Graphire 4 which shares its
BTN_LEFT and BTN_RIGHT in its pad and in the mouse.

Again, it's not a problem right now because the user space is currently dealing
with it, but for the Wayland libinput implementation, having something clear
will really help.

This patch series does not break current X11 behavior, the only change from the
user will be that an input device will appear as "Wacom ... Pad pad".

I tried to test/debug it as extensively as possible, but I do not guarantee any
mistake :(

Tested on:
- Bamboo 16FG 4x5
- Bamboo 2FG
- BambooFun 4x5
- Bamboo
- Cintiq 12WX
- Cintiq 21UX2
- Cintiq 21UX
- Cintiq 22HD
- Cintiq 22HDT
- Cintiq 24HD
- DTU2231
- Graphire3
- Intuos3 9x12
- Intuos4 WL
- Intuos5 touch M
- Intuos Pro S

Note: this patch series might requesting to apply the patch for input->phys
I just sent:
https://patchwork.kernel.org/patch/4404391/


Cheers,
Benjamin

Benjamin Tissoires (5):
  Input - wacom: create a separate input device for pads
  Input - wacom: split out the pad device for Intuos/Cintiq
  Input - wacom: split out the pad device for Bamboos
  Input - wacom: split out the pad device for DTUS
  Input - wacom: split out the pad device for Graphire G4 and MO

 drivers/input/tablet/wacom.h     |   2 +
 drivers/input/tablet/wacom_sys.c |  63 +++++++-
 drivers/input/tablet/wacom_wac.c | 328 ++++++++++++++++++++++++---------------
 drivers/input/tablet/wacom_wac.h |   2 +
 4 files changed, 259 insertions(+), 136 deletions(-)

-- 
1.9.0


             reply	other threads:[~2014-06-23 20:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-23 20:57 Benjamin Tissoires [this message]
2014-06-23 20:57 ` [PATCH 1/5] Input - wacom: create a separate input device for pads Benjamin Tissoires
2014-06-24  0:18   ` Ping Cheng
2014-06-24 14:00     ` Benjamin Tissoires
2014-07-11  0:18   ` Jason Gerecke
2014-07-11 13:17     ` [Linuxwacom-devel] " Benjamin Tissoires
2014-06-23 20:57 ` [PATCH 2/5] Input - wacom: split out the pad device for Intuos/Cintiq Benjamin Tissoires
2014-06-23 20:57 ` [PATCH 3/5] Input - wacom: split out the pad device for Bamboos Benjamin Tissoires
2014-06-23 20:57 ` [PATCH 4/5] Input - wacom: split out the pad device for DTUS Benjamin Tissoires
2014-06-23 20:57 ` [PATCH 5/5] Input - wacom: split out the pad device for Graphire G4 and MO Benjamin Tissoires
2014-07-11  1:21 ` [PATCH 0/5] Input - wacom: split out pad data from the stylus input device Jason Gerecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403557039-1487-1-git-send-email-benjamin.tissoires@redhat.com \
    --to=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=killertofu@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxwacom-devel@lists.sourceforge.net \
    --cc=pinglinux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).