From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Subject: [PATCH 12/13] leds: lp55xx-common: fix sysfs entry leak Date: Wed, 25 Jun 2014 19:08:55 +0200 Message-ID: <1403716136-32694-13-git-send-email-johan@kernel.org> References: <1403716136-32694-1-git-send-email-johan@kernel.org> Return-path: In-Reply-To: <1403716136-32694-1-git-send-email-johan@kernel.org> Sender: linux-leds-owner@vger.kernel.org To: Bryan Wu , Richard Purdie Cc: Dmitry Torokhov , Greg Kroah-Hartman , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Janne Kanniainen , Jiri Kosina , =?UTF-8?q?Bj=C3=B8rn=20Mork?= , Johan Hovold List-Id: linux-input@vger.kernel.org Make sure the sysfs group is removed when the LEDs are unregistered. Signed-off-by: Johan Hovold --- drivers/leds/leds-lp55xx-common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/leds/leds-lp55xx-common.c b/drivers/leds/leds-lp55xx-common.c index 88317b4f7bf3..3fbfb31602c7 100644 --- a/drivers/leds/leds-lp55xx-common.c +++ b/drivers/leds/leds-lp55xx-common.c @@ -520,6 +520,8 @@ void lp55xx_unregister_leds(struct lp55xx_led *led, struct lp55xx_chip *chip) for (i = 0; i < chip->num_leds; i++) { each = led + i; + sysfs_remove_group(&each->cdev.dev->kobj, + &lp55xx_led_attr_group); led_classdev_unregister(&each->cdev); flush_work(&each->brightness_work); } -- 1.8.5.5