linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jamie Lentin <jm@lentin.co.uk>
To: Jiri Kosina <jkosina@suse.cz>, Antonio Ospite <ao2@ao2.it>,
	Hans de Goede <hdegoede@redhat.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jamie Lentin <jm@lentin.co.uk>
Subject: [PATCH v4 3/4] Style fixes
Date: Sun, 13 Jul 2014 08:24:21 +0100	[thread overview]
Message-ID: <1405236262-8070-4-git-send-email-jm@lentin.co.uk> (raw)
In-Reply-To: <1405236262-8070-1-git-send-email-jm@lentin.co.uk>

Signed-off-by: Jamie Lentin <jm@lentin.co.uk>
---
 drivers/hid/hid-lenovo.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c
index d11e337..a1a693c 100644
--- a/drivers/hid/hid-lenovo.c
+++ b/drivers/hid/hid-lenovo.c
@@ -349,7 +349,7 @@ static int lenovo_probe_tpkbd(struct hid_device *hdev)
 	struct lenovo_drvdata_tpkbd *data_pointer;
 	size_t name_sz = strlen(dev_name(dev)) + 16;
 	char *name_mute, *name_micmute;
-	int i;
+	int i, ret;
 
 	/*
 	 * If this is the pointer half of the keyboard, input_mapping should
@@ -369,10 +369,9 @@ static int lenovo_probe_tpkbd(struct hid_device *hdev)
 	if (!hid_validate_values(hdev, HID_OUTPUT_REPORT, 3, 0, 2))
 		return -ENODEV;
 
-	if (sysfs_create_group(&hdev->dev.kobj,
-				&lenovo_attr_group_tpkbd)) {
+	ret = sysfs_create_group(&hdev->dev.kobj, &lenovo_attr_group_tpkbd);
+	if (ret)
 		hid_warn(hdev, "Could not create sysfs group\n");
-	}
 
 	data_pointer = devm_kzalloc(&hdev->dev,
 				    sizeof(struct lenovo_drvdata_tpkbd),
-- 
2.0.0


  parent reply	other threads:[~2014-07-13  7:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-13  7:24 [PATCH v4 0/4] Add support for Lenovo Compact Keyboard Jamie Lentin
2014-07-13  7:24 ` [PATCH v4 1/4] Rename hid-lenovo-tpkbd to hid-lenovo Jamie Lentin
2014-07-14  9:42   ` Antonio Ospite
2014-07-18  9:35     ` Jamie Lentin
2014-07-21 13:55       ` Antonio Ospite
2014-07-13  7:24 ` [PATCH v4 2/4] Make all base functions switch depending on product ID Jamie Lentin
2014-07-14 10:19   ` Antonio Ospite
2014-07-13  7:24 ` Jamie Lentin [this message]
2014-07-14 10:19   ` [PATCH v4 3/4] Style fixes Antonio Ospite
2014-07-13  7:24 ` [PATCH v4 4/4] Add support for Compact (Bluetooth|USB) keyboard with Trackpoint Jamie Lentin
2014-07-14 10:21   ` Antonio Ospite
2014-07-14 21:02 ` [PATCH v4 0/4] Add support for Lenovo Compact Keyboard Antonio Ospite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405236262-8070-4-git-send-email-jm@lentin.co.uk \
    --to=jm@lentin.co.uk \
    --cc=ao2@ao2.it \
    --cc=hdegoede@redhat.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).