From: Joe Perches <joe@perches.com>
To: Bivolaru Catalin <bivolaru.catalin@gmail.com>
Cc: kernel-janitors@vger.kernel.org, dmitry.torokhov@gmail.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
paul.gortmaker@windriver.com
Subject: Re: [PATCH] staging: input: sunkbd.c: Fix coding style
Date: Sun, 20 Jul 2014 08:52:54 -0700 [thread overview]
Message-ID: <1405871574.5135.24.camel@joe-AO725> (raw)
In-Reply-To: <20140720120103.GA5294@kalio-PC>
On Sun, 2014-07-20 at 15:01 +0300, Bivolaru Catalin wrote:
> Fix coding style with regard to missing spaces after , and the column limit
> that was violated after the first change.
Some checkpatch errors should be ignored.
These are some of them.
This change doesn't make it easier to read
or to find any array entry.
It's currently in groups of 16 (0x10).
This change would make it very difficult
to find any particular entry.
It might make some sense to change the last
line to add a trailing " 0, 0" entry as
the compiler does to make it a bit clearer
the table has 128 entries.
> diff --git a/drivers/input/keyboard/sunkbd.c b/drivers/input/keyboard/sunkbd.c
[]
> @@ -42,14 +42,15 @@ MODULE_DESCRIPTION(DRIVER_DESC);
> MODULE_LICENSE("GPL");
>
> static unsigned char sunkbd_keycode[128] = {
> - 0,128,114,129,115, 59, 60, 68, 61, 87, 62, 88, 63,100, 64,112,
> - 65, 66, 67, 56,103,119, 99, 70,105,130,131,108,106, 1, 2, 3,
> - 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 41, 14,110,113, 98, 55,
> - 116,132, 83,133,102, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25,
> - 26, 27,111,127, 71, 72, 73, 74,134,135,107, 0, 29, 30, 31, 32,
> - 33, 34, 35, 36, 37, 38, 39, 40, 43, 28, 96, 75, 76, 77, 82,136,
> - 104,137, 69, 42, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54,101,
> - 79, 80, 81, 0, 0, 0,138, 58,125, 57,126,109, 86, 78
> + 0, 128, 114, 129, 115, 59, 60, 68, 61, 87, 62, 88, 63, 100,
> + 64, 112, 65, 66, 67, 56, 103, 119, 99, 70, 105, 130, 131, 108,
> + 106, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13,
> + 41, 14, 110, 113, 98, 55, 116, 132, 83, 133, 102, 15, 16, 17,
> + 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 111, 127, 71, 72,
> + 73, 74, 134, 135, 107, 0, 29, 30, 31, 32, 33, 34, 35, 36,
> + 37, 38, 39, 40, 43, 28, 96, 75, 76, 77, 82, 136, 104, 137,
> + 69, 42, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 101,
> + 79, 80, 81, 0, 0, 0, 138, 58, 125, 57, 126, 109, 86, 78
> };
next prev parent reply other threads:[~2014-07-20 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-20 12:01 [PATCH] staging: input: sunkbd.c: Fix coding style Bivolaru Catalin
2014-07-20 15:52 ` Joe Perches [this message]
2014-07-20 20:19 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405871574.5135.24.camel@joe-AO725 \
--to=joe@perches.com \
--cc=bivolaru.catalin@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).