* [PATCH] doc: dt/bindings: input: Fix drv260x binding document
@ 2014-08-22 14:12 Dan Murphy
2014-08-22 14:15 ` Felipe Balbi
0 siblings, 1 reply; 5+ messages in thread
From: Dan Murphy @ 2014-08-22 14:12 UTC (permalink / raw)
To: devicetree, linux-input
Cc: linux-kernel, dmitry.torokhov, linux-arm-kernel, Dan Murphy
Update the drv260x dt binding document:
- Change the node name to the devices function not the
device name.
- Add vbat-supply to the example.
- Fix indentation of the example.
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
.../devicetree/bindings/input/ti,drv260x.txt | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/input/ti,drv260x.txt b/Documentation/devicetree/bindings/input/ti,drv260x.txt
index a9c8519..214e25d 100644
--- a/Documentation/devicetree/bindings/input/ti,drv260x.txt
+++ b/Documentation/devicetree/bindings/input/ti,drv260x.txt
@@ -37,15 +37,16 @@ Optional properties:
3.2 v.
Example:
-drv2605l: drv2605l@5a {
- compatible = "ti,drv2605l";
- reg = <0x5a>;
- enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
- mode = <DRV260X_LRA_MODE>;
- library-sel = <DRV260X_LIB_LRA>;
- vib-rated-mv = <3200>;
- vib-overdriver-mv = <3200>;
-};
+haptics:@5a {
+ compatible = "ti,drv2605l";
+ reg = <0x5a>;
+ vbat-supply = <&vbat>;
+ enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
+ mode = <DRV260X_LRA_MODE>;
+ library-sel = <DRV260X_LIB_LRA>;
+ vib-rated-mv = <3200>;
+ vib-overdriver-mv = <3200>;
+}
For more product information please see the link below:
http://www.ti.com/product/drv2605
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] doc: dt/bindings: input: Fix drv260x binding document
2014-08-22 14:12 [PATCH] doc: dt/bindings: input: Fix drv260x binding document Dan Murphy
@ 2014-08-22 14:15 ` Felipe Balbi
2014-08-22 14:25 ` Murphy, Dan
0 siblings, 1 reply; 5+ messages in thread
From: Felipe Balbi @ 2014-08-22 14:15 UTC (permalink / raw)
To: Dan Murphy
Cc: devicetree, linux-input, linux-kernel, dmitry.torokhov,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]
On Fri, Aug 22, 2014 at 09:12:21AM -0500, Dan Murphy wrote:
> Update the drv260x dt binding document:
> - Change the node name to the devices function not the
> device name.
> - Add vbat-supply to the example.
> - Fix indentation of the example.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> .../devicetree/bindings/input/ti,drv260x.txt | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/input/ti,drv260x.txt b/Documentation/devicetree/bindings/input/ti,drv260x.txt
> index a9c8519..214e25d 100644
> --- a/Documentation/devicetree/bindings/input/ti,drv260x.txt
> +++ b/Documentation/devicetree/bindings/input/ti,drv260x.txt
> @@ -37,15 +37,16 @@ Optional properties:
> 3.2 v.
> Example:
>
> -drv2605l: drv2605l@5a {
> - compatible = "ti,drv2605l";
> - reg = <0x5a>;
> - enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> - mode = <DRV260X_LRA_MODE>;
> - library-sel = <DRV260X_LIB_LRA>;
> - vib-rated-mv = <3200>;
> - vib-overdriver-mv = <3200>;
> -};
> +haptics:@5a {
haptics: haptics@5a ??
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] doc: dt/bindings: input: Fix drv260x binding document
2014-08-22 14:15 ` Felipe Balbi
@ 2014-08-22 14:25 ` Murphy, Dan
2014-08-22 14:45 ` Felipe Balbi
0 siblings, 1 reply; 5+ messages in thread
From: Murphy, Dan @ 2014-08-22 14:25 UTC (permalink / raw)
To: Balbi, Felipe
Cc: devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
linux-arm-kernel@lists.infradead.org
Felipe
On 08/22/2014 09:15 AM, Balbi, Felipe wrote:
> On Fri, Aug 22, 2014 at 09:12:21AM -0500, Dan Murphy wrote:
>> Update the drv260x dt binding document:
>> - Change the node name to the devices function not the
>> device name.
>> - Add vbat-supply to the example.
>> - Fix indentation of the example.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>> .../devicetree/bindings/input/ti,drv260x.txt | 19 ++++++++++---------
>> 1 file changed, 10 insertions(+), 9 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/input/ti,drv260x.txt b/Documentation/devicetree/bindings/input/ti,drv260x.txt
>> index a9c8519..214e25d 100644
>> --- a/Documentation/devicetree/bindings/input/ti,drv260x.txt
>> +++ b/Documentation/devicetree/bindings/input/ti,drv260x.txt
>> @@ -37,15 +37,16 @@ Optional properties:
>> 3.2 v.
>> Example:
>>
>> -drv2605l: drv2605l@5a {
>> - compatible = "ti,drv2605l";
>> - reg = <0x5a>;
>> - enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>> - mode = <DRV260X_LRA_MODE>;
>> - library-sel = <DRV260X_LIB_LRA>;
>> - vib-rated-mv = <3200>;
>> - vib-overdriver-mv = <3200>;
>> -};
>> +haptics:@5a {
>
> haptics: haptics@5a ??
>
I found both types of entries in the bindings docs.
There is no consistency within the input bindings documentation.
I have no issue doing it either way.
Dan
--
------------------
Dan Murphy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] doc: dt/bindings: input: Fix drv260x binding document
2014-08-22 14:25 ` Murphy, Dan
@ 2014-08-22 14:45 ` Felipe Balbi
2014-08-22 14:49 ` Murphy, Dan
0 siblings, 1 reply; 5+ messages in thread
From: Felipe Balbi @ 2014-08-22 14:45 UTC (permalink / raw)
To: Murphy, Dan
Cc: Balbi, Felipe, devicetree@vger.kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
dmitry.torokhov@gmail.com, linux-arm-kernel@lists.infradead.org
[-- Attachment #1: Type: text/plain, Size: 1607 bytes --]
Hi,
On Fri, Aug 22, 2014 at 09:25:13AM -0500, Murphy, Dan wrote:
> Felipe
>
> On 08/22/2014 09:15 AM, Balbi, Felipe wrote:
> > On Fri, Aug 22, 2014 at 09:12:21AM -0500, Dan Murphy wrote:
> >> Update the drv260x dt binding document:
> >> - Change the node name to the devices function not the
> >> device name.
> >> - Add vbat-supply to the example.
> >> - Fix indentation of the example.
> >>
> >> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> >> ---
> >> .../devicetree/bindings/input/ti,drv260x.txt | 19 ++++++++++---------
> >> 1 file changed, 10 insertions(+), 9 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/input/ti,drv260x.txt b/Documentation/devicetree/bindings/input/ti,drv260x.txt
> >> index a9c8519..214e25d 100644
> >> --- a/Documentation/devicetree/bindings/input/ti,drv260x.txt
> >> +++ b/Documentation/devicetree/bindings/input/ti,drv260x.txt
> >> @@ -37,15 +37,16 @@ Optional properties:
> >> 3.2 v.
> >> Example:
> >>
> >> -drv2605l: drv2605l@5a {
> >> - compatible = "ti,drv2605l";
> >> - reg = <0x5a>;
> >> - enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> >> - mode = <DRV260X_LRA_MODE>;
> >> - library-sel = <DRV260X_LIB_LRA>;
> >> - vib-rated-mv = <3200>;
> >> - vib-overdriver-mv = <3200>;
> >> -};
> >> +haptics:@5a {
> >
> > haptics: haptics@5a ??
> >
>
> I found both types of entries in the bindings docs.
> There is no consistency within the input bindings documentation.
I could swear neither two types have a colon character between node name
and its base address.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] doc: dt/bindings: input: Fix drv260x binding document
2014-08-22 14:45 ` Felipe Balbi
@ 2014-08-22 14:49 ` Murphy, Dan
0 siblings, 0 replies; 5+ messages in thread
From: Murphy, Dan @ 2014-08-22 14:49 UTC (permalink / raw)
To: Balbi, Felipe
Cc: devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
linux-arm-kernel@lists.infradead.org
Felipe
On 08/22/2014 09:45 AM, Balbi, Felipe wrote:
> Hi,
>
> On Fri, Aug 22, 2014 at 09:25:13AM -0500, Murphy, Dan wrote:
>> Felipe
>>
>> On 08/22/2014 09:15 AM, Balbi, Felipe wrote:
>>> On Fri, Aug 22, 2014 at 09:12:21AM -0500, Dan Murphy wrote:
>>>> Update the drv260x dt binding document:
>>>> - Change the node name to the devices function not the
>>>> device name.
>>>> - Add vbat-supply to the example.
>>>> - Fix indentation of the example.
>>>>
>>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>>>> ---
>>>> .../devicetree/bindings/input/ti,drv260x.txt | 19 ++++++++++---------
>>>> 1 file changed, 10 insertions(+), 9 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/input/ti,drv260x.txt b/Documentation/devicetree/bindings/input/ti,drv260x.txt
>>>> index a9c8519..214e25d 100644
>>>> --- a/Documentation/devicetree/bindings/input/ti,drv260x.txt
>>>> +++ b/Documentation/devicetree/bindings/input/ti,drv260x.txt
>>>> @@ -37,15 +37,16 @@ Optional properties:
>>>> 3.2 v.
>>>> Example:
>>>>
>>>> -drv2605l: drv2605l@5a {
>>>> - compatible = "ti,drv2605l";
>>>> - reg = <0x5a>;
>>>> - enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>>>> - mode = <DRV260X_LRA_MODE>;
>>>> - library-sel = <DRV260X_LIB_LRA>;
>>>> - vib-rated-mv = <3200>;
>>>> - vib-overdriver-mv = <3200>;
>>>> -};
>>>> +haptics:@5a {
>>>
>>> haptics: haptics@5a ??
>>>
>>
>> I found both types of entries in the bindings docs.
>> There is no consistency within the input bindings documentation.
>
> I could swear neither two types have a colon character between node name
> and its base address.
>
I will add it to the fixes.
Dan
--
------------------
Dan Murphy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-08-22 14:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-22 14:12 [PATCH] doc: dt/bindings: input: Fix drv260x binding document Dan Murphy
2014-08-22 14:15 ` Felipe Balbi
2014-08-22 14:25 ` Murphy, Dan
2014-08-22 14:45 ` Felipe Balbi
2014-08-22 14:49 ` Murphy, Dan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).