From: Stefan Berzl <stefanberzl@gmail.com>
To: "José Expósito" <jose.exposito89@gmail.com>
Cc: jikos@kernel.org, benjamin.tissoires@redhat.com,
spbnick@gmail.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Status on hid xppen patch
Date: Mon, 16 May 2022 12:45:48 +0200 [thread overview]
Message-ID: <140fe69a-c37a-cce4-c7c1-0344de6f1bf1@gmail.com> (raw)
In-Reply-To: <20220516090829.GA20623@elementary>
Yo José,
>>> I had to introduce new functionalities to the templating system of the
>>> driver, that's the reason for the KUnit tests.
>>> The last patch is work in progress (hopefully I'll have time to finish
>>> it this weekend), only the HID descriptors are missing.
>>
>> I hope you make it, but otherwise you can always use mine, as it's quite
>> the same as yours. Only the logical minimum and maximum are -60 and 60.
>
> You are right, 60 and not 127 is the right value. Actually, I think
> that -61 - 60 is the correct range, because of the 0.
> Running "libinput-debug-tablet" makes it easier to debug.
>
> I also had to fix the descriptor to avoid an issue with the pressure
> causing issues with the Deco L, but other than that, it should be
> correct now.
I don't think the two's complement thing has any bearing here, because
there are still several numbers left in both directions. Also I couldn't
get the mini 7 to produce tilt values either >60 or <-60,
but I'm sure you'll get behind it.
> Also, I don't know if you have seen this error after connecting the
> tablet:
>
> xhci_hcd 0000:2a:00.3: WARN urb submitted to disabled ep
> usb 3-2: reset full-speed USB device number 6 using xhci_hcd
> usb 3-2: reset full-speed USB device number 6 using xhci_hcd
> [...]
>
> It happens with the Deco Mini 4, even when using the hid-generic
> driver. I need to rebase my patches on 5.19 and test again, just to
> make sure the problem is not somewhere else.
Can't say I have seen it. The only thing I can think of is that I was
using the async urb functions and that delay did something about it.
Kind regards
Stefan Berzl
next prev parent reply other threads:[~2022-05-16 10:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 22:29 Status on hid xppen patch Stefan Berzl
2022-04-23 17:23 ` José Expósito
2022-04-23 23:19 ` Stefan Berzl
2022-04-24 9:32 ` José Expósito
2022-05-12 20:59 ` José Expósito
2022-05-13 17:22 ` Stefan Berzl
2022-05-16 9:08 ` José Expósito
2022-05-16 10:45 ` Stefan Berzl [this message]
2022-05-16 11:21 ` José Expósito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=140fe69a-c37a-cce4-c7c1-0344de6f1bf1@gmail.com \
--to=stefanberzl@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=jose.exposito89@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spbnick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).