From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
To: Nick Dyer <nick.dyer@itdev.co.uk>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table
Date: Tue, 09 Sep 2014 12:54:43 +0200 [thread overview]
Message-ID: <1410260083.2857.9.camel@collabora.co.uk> (raw)
In-Reply-To: <540ED671.5020103@itdev.co.uk>
[-- Attachment #1: Type: text/plain, Size: 1297 bytes --]
On Tue, 2014-09-09 at 11:29 +0100, Nick Dyer wrote:
> On 09/09/14 11:21, Javier Martinez Canillas wrote:
> > On 09/09/2014 09:52 AM, Sjoerd Simons wrote:
> >> For i2c devices in OF the modalias exposed to userspace is i2c:<node
> >> type>, for the Maxtouch driver this is i2c:maxtouch.
> >>
> >> Add maxtouch to the i2c id table such that userspace can correctly
> >> load the module for the device and drop the OF table as it's not
> >> needed for i2c devices.
> > I see that Lee is working to allow the I2C subsystem to not need an I2C ID
> > table to match [0]. I'll let Lee to comment what the future plans are and if
> > his series are going to solve your issue since I'm not that familiar with the
> > I2C core.
>
> I can see the benefit of not having the duplication. Am I correct that
> you're saying that it might make more sense to remove the i2c ids rather
> than the OF table, if Lee's changes are accepted?
You would still need the i2C table for non-OF platforms ofcourse.
I'm not sure what happens with the modalias as exposed to userspace with
Lee's patchset, if that gets changed to prefer an of: type instead of
the current i2c: prefixed ones this patch (at that point) isn't needed.
--
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Collabora Ltd.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6170 bytes --]
next prev parent reply other threads:[~2014-09-09 10:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 7:52 [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table Sjoerd Simons
2014-09-09 10:21 ` Javier Martinez Canillas
2014-09-09 10:29 ` Nick Dyer
2014-09-09 10:54 ` Sjoerd Simons [this message]
2014-09-10 9:28 ` Lee Jones
2014-09-11 8:00 ` Sjoerd Simons
2014-09-11 8:38 ` Javier Martinez Canillas
2014-09-11 9:19 ` Nick Dyer
2014-09-11 9:54 ` Javier Martinez Canillas
2014-09-11 11:08 ` Wolfram Sang
2014-09-11 11:24 ` Javier Martinez Canillas
2014-09-11 11:35 ` Wolfram Sang
2014-09-11 11:41 ` Javier Martinez Canillas
2014-09-11 12:24 ` Nick Dyer
2014-09-09 12:36 ` Nick Dyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410260083.2857.9.camel@collabora.co.uk \
--to=sjoerd.simons@collabora.co.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=javier.martinez@collabora.co.uk \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=nick.dyer@itdev.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).