* [PATCH 1/4] HID: wacom - Add default permission defines for sysfs attributes
@ 2014-09-10 18:40 Ping Cheng
2014-09-10 18:59 ` Benjamin Tissoires
0 siblings, 1 reply; 2+ messages in thread
From: Ping Cheng @ 2014-09-10 18:40 UTC (permalink / raw)
To: jkosina; +Cc: killertofu, linux-input, Ping Cheng, Paul A. Tessier
RW : ug=rw,o=r
WO : ug=w
Signed-off-by: Paul A. Tessier <phernost@gmail.com>
Signed-Off-by: Ping Cheng <pingc@wacom.com>
Tested-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/hid/wacom_sys.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
index f0db7ec..2ce102b 100644
--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wacom_sys.c
@@ -23,6 +23,9 @@
#define WAC_CMD_ICON_BT_XFER 0x26
#define WAC_CMD_RETRIES 10
+#define DEV_ATTR_RW_PERM (S_IRUGO | S_IWUSR | S_IWGRP)
+#define DEV_ATTR_WO_PERM (S_IWUSR | S_IWGRP)
+
static int wacom_get_report(struct hid_device *hdev, u8 type, u8 id,
void *buf, size_t size, unsigned int retries)
{
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/4] HID: wacom - Add default permission defines for sysfs attributes
2014-09-10 18:40 [PATCH 1/4] HID: wacom - Add default permission defines for sysfs attributes Ping Cheng
@ 2014-09-10 18:59 ` Benjamin Tissoires
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Tissoires @ 2014-09-10 18:59 UTC (permalink / raw)
To: Ping Cheng
Cc: Jiri Kosina, Jason Gerecke, linux-input, Ping Cheng,
Paul A. Tessier
On Wed, Sep 10, 2014 at 2:40 PM, Ping Cheng <pinglinux@gmail.com> wrote:
> RW : ug=rw,o=r
> WO : ug=w
>
> Signed-off-by: Paul A. Tessier <phernost@gmail.com>
> Signed-Off-by: Ping Cheng <pingc@wacom.com>
> Tested-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
> drivers/hid/wacom_sys.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index f0db7ec..2ce102b 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -23,6 +23,9 @@
> #define WAC_CMD_ICON_BT_XFER 0x26
> #define WAC_CMD_RETRIES 10
>
> +#define DEV_ATTR_RW_PERM (S_IRUGO | S_IWUSR | S_IWGRP)
> +#define DEV_ATTR_WO_PERM (S_IWUSR | S_IWGRP)
> +
I guess you missed the correct split with 2/4 :)
Please also add in this patch where these defines are used.
Cheers,
Benjamin
> static int wacom_get_report(struct hid_device *hdev, u8 type, u8 id,
> void *buf, size_t size, unsigned int retries)
> {
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-10 18:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-10 18:40 [PATCH 1/4] HID: wacom - Add default permission defines for sysfs attributes Ping Cheng
2014-09-10 18:59 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).