* [PATCH] usbhid: add another mouse that needs QUIRK_ALWAYS_POLL
@ 2014-09-30 10:54 Oliver Neukum
2014-10-01 7:23 ` Jiri Kosina
0 siblings, 1 reply; 4+ messages in thread
From: Oliver Neukum @ 2014-09-30 10:54 UTC (permalink / raw)
To: jkosina, linux-input, johan; +Cc: Oliver Neukum
There is a second mouse sharing the same vendor strings
but different IDs.
Signed-off-by: Oliver Neukum <oneukum@suse.de>
---
drivers/hid/hid-ids.h | 1 +
drivers/hid/usbhid/hid-quirks.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index b303a62..5a7072d 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -733,6 +733,7 @@
#define USB_DEVICE_ID_PI_ENGINEERING_VEC_USB_FOOTPEDAL 0xff
#define USB_VENDOR_ID_PIXART 0x093a
+#define USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE_ID2 0x0137
#define USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE 0x2510
#define USB_DEVICE_ID_PIXART_OPTICAL_TOUCH_SCREEN 0x8001
#define USB_DEVICE_ID_PIXART_OPTICAL_TOUCH_SCREEN1 0x8002
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index 79f94ae..ce27c62 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -80,6 +80,8 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_PENMOUNT, USB_DEVICE_ID_PENMOUNT_1610, HID_QUIRK_NOGET },
{ USB_VENDOR_ID_PENMOUNT, USB_DEVICE_ID_PENMOUNT_1640, HID_QUIRK_NOGET },
{ USB_VENDOR_ID_PIXART, USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE, HID_QUIRK_ALWAYS_POLL },
+ /* OEM version same strings but different IDs */
+ { USB_VENDOR_ID_KYE, USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE_ID2, HID_QUIRK_ALWAYS_POLL },
{ USB_VENDOR_ID_PIXART, USB_DEVICE_ID_PIXART_OPTICAL_TOUCH_SCREEN, HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_PIXART, USB_DEVICE_ID_PIXART_OPTICAL_TOUCH_SCREEN1, HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_PIXART, USB_DEVICE_ID_PIXART_OPTICAL_TOUCH_SCREEN2, HID_QUIRK_NO_INIT_REPORTS },
--
1.8.4.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usbhid: add another mouse that needs QUIRK_ALWAYS_POLL
2014-09-30 10:54 [PATCH] usbhid: add another mouse that needs QUIRK_ALWAYS_POLL Oliver Neukum
@ 2014-10-01 7:23 ` Jiri Kosina
2014-10-01 8:14 ` Oliver Neukum
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Kosina @ 2014-10-01 7:23 UTC (permalink / raw)
To: Oliver Neukum; +Cc: linux-input, johan
On Tue, 30 Sep 2014, Oliver Neukum wrote:
> There is a second mouse sharing the same vendor strings
> but different IDs.
>
> Signed-off-by: Oliver Neukum <oneukum@suse.de>
> ---
> drivers/hid/hid-ids.h | 1 +
> drivers/hid/usbhid/hid-quirks.c | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index b303a62..5a7072d 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -733,6 +733,7 @@
> #define USB_DEVICE_ID_PI_ENGINEERING_VEC_USB_FOOTPEDAL 0xff
>
> #define USB_VENDOR_ID_PIXART 0x093a
> +#define USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE_ID2 0x0137
> #define USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE 0x2510
> #define USB_DEVICE_ID_PIXART_OPTICAL_TOUCH_SCREEN 0x8001
> #define USB_DEVICE_ID_PIXART_OPTICAL_TOUCH_SCREEN1 0x8002
> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> index 79f94ae..ce27c62 100644
> --- a/drivers/hid/usbhid/hid-quirks.c
> +++ b/drivers/hid/usbhid/hid-quirks.c
> @@ -80,6 +80,8 @@ static const struct hid_blacklist {
> { USB_VENDOR_ID_PENMOUNT, USB_DEVICE_ID_PENMOUNT_1610, HID_QUIRK_NOGET },
> { USB_VENDOR_ID_PENMOUNT, USB_DEVICE_ID_PENMOUNT_1640, HID_QUIRK_NOGET },
> { USB_VENDOR_ID_PIXART, USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE, HID_QUIRK_ALWAYS_POLL },
> + /* OEM version same strings but different IDs */
> + { USB_VENDOR_ID_KYE, USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE_ID2, HID_QUIRK_ALWAYS_POLL },
I don't like the added comment, it makes the list look ugly (as no other
device has such a comment). The details are in the git changelog anyway.
Are you fine with me removing the comment before commiting the patch?
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usbhid: add another mouse that needs QUIRK_ALWAYS_POLL
2014-10-01 7:23 ` Jiri Kosina
@ 2014-10-01 8:14 ` Oliver Neukum
2014-10-01 12:32 ` Jiri Kosina
0 siblings, 1 reply; 4+ messages in thread
From: Oliver Neukum @ 2014-10-01 8:14 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-input, johan
On Wed, 2014-10-01 at 09:23 +0200, Jiri Kosina wrote:
> On Tue, 30 Sep 2014, Oliver Neukum wrote:
>
> > There is a second mouse sharing the same vendor strings
> > but different IDs.
> >
> > Signed-off-by: Oliver Neukum <oneukum@suse.de>
> > ---
> > drivers/hid/hid-ids.h | 1 +
> > drivers/hid/usbhid/hid-quirks.c | 2 ++
> > 2 files changed, 3 insertions(+)
> >
> > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> > index b303a62..5a7072d 100644
> > --- a/drivers/hid/hid-ids.h
> > +++ b/drivers/hid/hid-ids.h
> > @@ -733,6 +733,7 @@
> > #define USB_DEVICE_ID_PI_ENGINEERING_VEC_USB_FOOTPEDAL 0xff
> >
> > #define USB_VENDOR_ID_PIXART 0x093a
> > +#define USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE_ID2 0x0137
> > #define USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE 0x2510
> > #define USB_DEVICE_ID_PIXART_OPTICAL_TOUCH_SCREEN 0x8001
> > #define USB_DEVICE_ID_PIXART_OPTICAL_TOUCH_SCREEN1 0x8002
> > diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> > index 79f94ae..ce27c62 100644
> > --- a/drivers/hid/usbhid/hid-quirks.c
> > +++ b/drivers/hid/usbhid/hid-quirks.c
> > @@ -80,6 +80,8 @@ static const struct hid_blacklist {
> > { USB_VENDOR_ID_PENMOUNT, USB_DEVICE_ID_PENMOUNT_1610, HID_QUIRK_NOGET },
> > { USB_VENDOR_ID_PENMOUNT, USB_DEVICE_ID_PENMOUNT_1640, HID_QUIRK_NOGET },
> > { USB_VENDOR_ID_PIXART, USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE, HID_QUIRK_ALWAYS_POLL },
> > + /* OEM version same strings but different IDs */
> > + { USB_VENDOR_ID_KYE, USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE_ID2, HID_QUIRK_ALWAYS_POLL },
>
> I don't like the added comment, it makes the list look ugly (as no other
> device has such a comment). The details are in the git changelog anyway.
>
> Are you fine with me removing the comment before commiting the patch?
If you wish to remove it, please do so. However, if people then complain
that I mixed up vendor IDs, will you handle that? ;)
Regards
Oliver
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usbhid: add another mouse that needs QUIRK_ALWAYS_POLL
2014-10-01 8:14 ` Oliver Neukum
@ 2014-10-01 12:32 ` Jiri Kosina
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2014-10-01 12:32 UTC (permalink / raw)
To: Oliver Neukum; +Cc: linux-input, johan
On Wed, 1 Oct 2014, Oliver Neukum wrote:
> > > --- a/drivers/hid/usbhid/hid-quirks.c
> > > +++ b/drivers/hid/usbhid/hid-quirks.c
> > > @@ -80,6 +80,8 @@ static const struct hid_blacklist {
> > > { USB_VENDOR_ID_PENMOUNT, USB_DEVICE_ID_PENMOUNT_1610, HID_QUIRK_NOGET },
> > > { USB_VENDOR_ID_PENMOUNT, USB_DEVICE_ID_PENMOUNT_1640, HID_QUIRK_NOGET },
> > > { USB_VENDOR_ID_PIXART, USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE, HID_QUIRK_ALWAYS_POLL },
> > > + /* OEM version same strings but different IDs */
> > > + { USB_VENDOR_ID_KYE, USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE_ID2, HID_QUIRK_ALWAYS_POLL },
> >
> > I don't like the added comment, it makes the list look ugly (as no other
> > device has such a comment). The details are in the git changelog anyway.
> >
> > Are you fine with me removing the comment before commiting the patch?
>
> If you wish to remove it, please do so.
Thanks, I removed it and applied.
> However, if people then complain that I mixed up vendor IDs, will you
> handle that? ;)
I am pretty good at running git blame and looking into changelogs, no
worries :)
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-01 12:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-30 10:54 [PATCH] usbhid: add another mouse that needs QUIRK_ALWAYS_POLL Oliver Neukum
2014-10-01 7:23 ` Jiri Kosina
2014-10-01 8:14 ` Oliver Neukum
2014-10-01 12:32 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).