From: Vignesh R <vigneshr@ti.com>
To: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Jonathan Cameron <jic23@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>, Felipe Balbi <balbi@ti.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Jan Kardell <jan.kardell@telliq.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Brad Griffis <bgriffis@ti.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-iio@vger.kernel.org, linux-input@vger.kernel.org,
Vignesh R <vigneshr@ti.com>
Subject: [PATCH 3/4] arm: boot: dts: am335x-evm: Make charge delay a DT parameter for tsc
Date: Mon, 27 Oct 2014 16:38:30 +0530 [thread overview]
Message-ID: <1414408111-2631-4-git-send-email-vigneshr@ti.com> (raw)
In-Reply-To: <1414408111-2631-1-git-send-email-vigneshr@ti.com>
The charge delay value is by default 0xB000. But it can be set to lower
values on some boards as long as false pen-ups are avoided. Lowering the
value increases the sampling rate (though current sampling rate is
sufficient for tsc operation). Hence charge delay has been made a DT
parameter.
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
.../devicetree/bindings/input/touchscreen/ti-tsc-adc.txt | 13 +++++++++++++
arch/arm/boot/dts/am335x-evm.dts | 1 +
2 files changed, 14 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
index 878549ba814d..ac62769e70e4 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
+++ b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
@@ -28,6 +28,18 @@ Required properties:
ti,adc-channels: List of analog inputs available for ADC.
AIN0 = 0, AIN1 = 1 and so on till AIN7 = 7.
+Optional properties:
+- child "tsc"
+ ti,charge-delay: Length of touch screen charge delay step in terms of
+ ADC clock cycles. Charge delay value should be large in order
+ to avoid false pen-up events. This value affects the overall
+ sampling speed hence need to be kept as low as possible while
+ avoiding false pen-up event. Start from a lower value say 0x400
+ and increase value until false pen-up events are avoided. The
+ pen-up detection happens immediately after the charge step
+ so this does in fact function as a hardware knob for adjusting
+ the amount of "settling time".
+
Example:
tscadc: tscadc@44e0d000 {
compatible = "ti,am3359-tscadc";
@@ -36,6 +48,7 @@ Example:
ti,x-plate-resistance = <200>;
ti,coordiante-readouts = <5>;
ti,wire-config = <0x00 0x11 0x22 0x33>;
+ ti,charge-delay = <0xB000>;
};
adc {
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index e2156a583de7..80be0462298b 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -641,6 +641,7 @@
ti,x-plate-resistance = <200>;
ti,coordinate-readouts = <5>;
ti,wire-config = <0x00 0x11 0x22 0x33>;
+ ti,charge-delay = <0xB000>;
};
adc {
--
1.9.1
next prev parent reply other threads:[~2014-10-27 11:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 11:08 [PATCH 0/4] Touchscreen performance related fixes Vignesh R
2014-10-27 11:08 ` [PATCH 1/4] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps Vignesh R
2014-10-31 21:03 ` Hartmut Knaack
2014-11-07 5:48 ` Vignesh R
2014-11-06 14:19 ` Richard Cochran
2014-11-07 5:34 ` Vignesh R
2014-11-07 8:00 ` Richard Cochran
2014-11-10 10:46 ` Vignesh R
[not found] ` <545C59CD.3070707-l0cyMroinI0@public.gmane.org>
2014-11-07 10:17 ` Richard Cochran
2014-10-27 11:08 ` [PATCH 2/4] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R
[not found] ` <1414408111-2631-3-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2014-11-03 15:05 ` Lee Jones
2014-11-07 5:48 ` Vignesh R
2014-10-27 11:08 ` Vignesh R [this message]
2014-10-31 21:09 ` [PATCH 3/4] arm: boot: dts: am335x-evm: Make charge delay a DT parameter for tsc Hartmut Knaack
2014-11-07 5:48 ` Vignesh R
2014-10-27 11:08 ` [PATCH 4/4] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter Vignesh R
2014-10-27 17:34 ` [PATCH 0/4] Touchscreen performance related fixes Sebastian Andrzej Siewior
2014-10-27 19:02 ` Griffis, Brad
2014-11-03 12:17 ` Sebastian Andrzej Siewior
[not found] ` <54577258.9080508-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2014-11-04 11:44 ` Vignesh R
[not found] ` <5458BC0B.1040803-l0cyMroinI0@public.gmane.org>
2014-11-04 12:37 ` Sebastian Andrzej Siewior
[not found] ` <5458C87F.80409-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2014-11-05 12:08 ` Vignesh R
2014-11-17 12:18 ` Vignesh R
2014-11-03 18:09 ` Richard Cochran
[not found] ` <20141103180920.GA20779-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-11-06 7:42 ` Vignesh R
2014-11-12 13:00 ` Johannes Pointner
2014-11-13 12:23 ` Vignesh R
[not found] ` <5464A2B5.3020207-l0cyMroinI0@public.gmane.org>
2014-11-17 11:39 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414408111-2631-4-git-send-email-vigneshr@ti.com \
--to=vigneshr@ti.com \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=bgriffis@ti.com \
--cc=bigeasy@linutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jan.kardell@telliq.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=paul.gortmaker@windriver.com \
--cc=pawel.moll@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).