From: Bastien Nocera <hadess@hadess.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@euromail.se>,
linux-input@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@gmail.com>
Subject: Re: [PATCH v2] Input: driver for the Goodix touchpanel
Date: Wed, 29 Oct 2014 01:54:51 +0100 [thread overview]
Message-ID: <1414544091.2406.26.camel@hadess.net> (raw)
In-Reply-To: <20141028230443.GA19675@dtor-ws>
On Tue, 2014-10-28 at 16:04 -0700, Dmitry Torokhov wrote:
> On Tue, Oct 28, 2014 at 11:31:30PM +0100, Bastien Nocera wrote:
<snip>
> > > Please try changing FIXMEs exactly as they were and see if the driver
> > > still works properly.
> >
> > I did, and it still works properly. I also don't understand how it could
> > have worked properly before...
> >
> > Should I still add those linefeeds to all the print statements in the
> > driver?
>
> Yes please.
Done, and new version sent.
Cheers
next prev parent reply other threads:[~2014-10-29 0:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 14:43 [PATCH v2] Input: driver for the Goodix touchpanel Bastien Nocera
2014-10-07 20:58 ` Dmitry Torokhov
2014-10-28 17:55 ` Bastien Nocera
2014-10-28 18:05 ` Dmitry Torokhov
2014-10-28 18:59 ` Bastien Nocera
2014-10-28 19:14 ` Dmitry Torokhov
2014-10-28 22:31 ` Bastien Nocera
2014-10-28 23:04 ` Dmitry Torokhov
2014-10-29 0:54 ` Bastien Nocera [this message]
2014-10-28 19:16 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414544091.2406.26.camel@hadess.net \
--to=hadess@hadess.net \
--cc=benjamin.tissoires@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).