From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Nocera Subject: Re: [PATCH v2] Input: driver for the Goodix touchpanel Date: Wed, 29 Oct 2014 01:54:51 +0100 Message-ID: <1414544091.2406.26.camel@hadess.net> References: <1411569838.29315.22.camel@hadess.net> <20141007205803.GJ16469@dtor-ws> <1414518921.2406.11.camel@hadess.net> <20141028180538.GA22157@dtor-ws> <1414522745.2406.14.camel@hadess.net> <20141028191446.GA7461@dtor-ws> <1414535490.2406.20.camel@hadess.net> <20141028230443.GA19675@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from relay6-d.mail.gandi.net ([217.70.183.198]:42905 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751515AbaJ2Azg (ORCPT ); Tue, 28 Oct 2014 20:55:36 -0400 In-Reply-To: <20141028230443.GA19675@dtor-ws> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Henrik Rydberg , linux-input@vger.kernel.org, Benjamin Tissoires On Tue, 2014-10-28 at 16:04 -0700, Dmitry Torokhov wrote: > On Tue, Oct 28, 2014 at 11:31:30PM +0100, Bastien Nocera wrote: > > > Please try changing FIXMEs exactly as they were and see if the driver > > > still works properly. > > > > I did, and it still works properly. I also don't understand how it could > > have worked properly before... > > > > Should I still add those linefeeds to all the print statements in the > > driver? > > Yes please. Done, and new version sent. Cheers