From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vignesh R Subject: [PATCH v4 1/6] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps Date: Fri, 14 Nov 2014 10:37:26 +0530 Message-ID: <1415941651-28962-2-git-send-email-vigneshr@ti.com> References: <1415941651-28962-1-git-send-email-vigneshr@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1415941651-28962-1-git-send-email-vigneshr@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Benoit Cousson , Tony Lindgren , Russell King , Jonathan Cameron , Hartmut Knaack , richardcochran@gmail.com, Dmitry Torokhov , Lee Jones , Sebastian Andrzej Siewior Cc: Lars-Peter Clausen , Peter Meerwald , Samuel Ortiz , Felipe Balbi , Vignesh R , Brad Griffis , Sanjeev Sharma , Paul Gortmaker , Jan Kardell , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org List-Id: linux-input@vger.kernel.org =46rom: Brad Griffis This patch makes the initial changes required to workaround TSC-false pen-up interrupts. It is required to implement these changes in order t= o remove udelay in the TSC interrupt handler and false pen-up events. The charge step is to be executed immediately after sampling X+. Hence TSC is made to use higher numbered steps (steps 5 to 16 for 5 co-ordina= te readouts, 4 wire TSC configuration) and ADC to use lower ones. Further X co-ordinate readouts must be the last to be sampled, thus co-ordinate= s are sampled in the order Y-Z-X. Signed-off-by: Brad Griffis [vigneshr@ti.com: Ported the patch from v3.12 to v3.18rc2] Signed-off-by: Vignesh R Acked-by: Jonathan Cameron --- drivers/iio/adc/ti_am335x_adc.c | 5 ++-- drivers/input/touchscreen/ti_am335x_tsc.c | 42 ++++++++++++++++++-----= -------- 2 files changed, 26 insertions(+), 21 deletions(-) diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335= x_adc.c index b730864731e8..adba23246474 100644 --- a/drivers/iio/adc/ti_am335x_adc.c +++ b/drivers/iio/adc/ti_am335x_adc.c @@ -86,19 +86,18 @@ static void tiadc_step_config(struct iio_dev *indio= _dev) { struct tiadc_device *adc_dev =3D iio_priv(indio_dev); unsigned int stepconfig; - int i, steps; + int i, steps =3D 0; =20 /* * There are 16 configurable steps and 8 analog input * lines available which are shared between Touchscreen and ADC. * - * Steps backwards i.e. from 16 towards 0 are used by ADC + * Steps forwards i.e. from 0 towards 16 are used by ADC * depending on number of input lines needed. * Channel would represent which analog input * needs to be given to ADC to digitalize data. */ =20 - steps =3D TOTAL_STEPS - adc_dev->channels; if (iio_buffer_enabled(indio_dev)) stepconfig =3D STEPCONFIG_AVG_16 | STEPCONFIG_FIFO1 | STEPCONFIG_MODE_SWCNT; diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/= touchscreen/ti_am335x_tsc.c index 2ce649520fe0..1aeac9675fe7 100644 --- a/drivers/input/touchscreen/ti_am335x_tsc.c +++ b/drivers/input/touchscreen/ti_am335x_tsc.c @@ -121,7 +121,7 @@ static void titsc_step_config(struct titsc *ts_dev) { unsigned int config; int i; - int end_step; + int end_step, first_step, tsc_steps; u32 stepenable; =20 config =3D STEPCONFIG_MODE_HWSYNC | @@ -140,9 +140,11 @@ static void titsc_step_config(struct titsc *ts_dev= ) break; } =20 - /* 1 =E2=80=A6 coordinate_readouts is for X */ - end_step =3D ts_dev->coordinate_readouts; - for (i =3D 0; i < end_step; i++) { + tsc_steps =3D ts_dev->coordinate_readouts * 2 + 2; + first_step =3D TOTAL_STEPS - tsc_steps; + /* Steps 16 to 16-coordinate_readouts is for X */ + end_step =3D first_step + tsc_steps; + for (i =3D end_step - ts_dev->coordinate_readouts; i < end_step; i++)= { titsc_writel(ts_dev, REG_STEPCONFIG(i), config); titsc_writel(ts_dev, REG_STEPDELAY(i), STEPCONFIG_OPENDLY); } @@ -164,9 +166,9 @@ static void titsc_step_config(struct titsc *ts_dev) break; } =20 - /* coordinate_readouts =E2=80=A6 coordinate_readouts * 2 is for Y */ - end_step =3D ts_dev->coordinate_readouts * 2; - for (i =3D ts_dev->coordinate_readouts; i < end_step; i++) { + /* 1 ... coordinate_readouts is for Y */ + end_step =3D first_step + ts_dev->coordinate_readouts; + for (i =3D first_step; i < end_step; i++) { titsc_writel(ts_dev, REG_STEPCONFIG(i), config); titsc_writel(ts_dev, REG_STEPDELAY(i), STEPCONFIG_OPENDLY); } @@ -179,7 +181,7 @@ static void titsc_step_config(struct titsc *ts_dev) titsc_writel(ts_dev, REG_CHARGECONFIG, config); titsc_writel(ts_dev, REG_CHARGEDELAY, CHARGEDLY_OPENDLY); =20 - /* coordinate_readouts * 2 =E2=80=A6 coordinate_readouts * 2 + 2 is f= or Z */ + /* coordinate_readouts + 1 ... coordinate_readouts + 2 is for Z */ config =3D STEPCONFIG_MODE_HWSYNC | STEPCONFIG_AVG_16 | ts_dev->bit_yp | ts_dev->bit_xn | STEPCONFIG_INM_ADCREFM | @@ -194,8 +196,11 @@ static void titsc_step_config(struct titsc *ts_dev= ) titsc_writel(ts_dev, REG_STEPDELAY(end_step), STEPCONFIG_OPENDLY); =20 - /* The steps1 =E2=80=A6 end and bit 0 for TS_Charge */ - stepenable =3D (1 << (end_step + 2)) - 1; + /* The steps end ... end - readouts * 2 + 2 and bit 0 for TS_Charge *= / + stepenable =3D 1; + for (i =3D 0; i < tsc_steps; i++) + stepenable |=3D 1 << (first_step + i + 1); + ts_dev->step_mask =3D stepenable; am335x_tsc_se_set_cache(ts_dev->mfd_tscadc, ts_dev->step_mask); } @@ -209,6 +214,7 @@ static void titsc_read_coordinates(struct titsc *ts= _dev, unsigned int read, diff; unsigned int i, channel; unsigned int creads =3D ts_dev->coordinate_readouts; + unsigned int first_step =3D TOTAL_STEPS - (creads * 2 + 2); =20 *z1 =3D *z2 =3D 0; if (fifocount % (creads * 2 + 2)) @@ -226,7 +232,7 @@ static void titsc_read_coordinates(struct titsc *ts= _dev, =20 channel =3D (read & 0xf0000) >> 16; read &=3D 0xfff; - if (channel < creads) { + if (channel > first_step + creads + 2) { diff =3D abs(read - prev_val_x); if (diff < prev_diff_x) { prev_diff_x =3D diff; @@ -234,19 +240,19 @@ static void titsc_read_coordinates(struct titsc *= ts_dev, } prev_val_x =3D read; =20 - } else if (channel < creads * 2) { + } else if (channel =3D=3D first_step + creads + 1) { + *z1 =3D read; + + } else if (channel =3D=3D first_step + creads + 2) { + *z2 =3D read; + + } else if (channel > first_step) { diff =3D abs(read - prev_val_y); if (diff < prev_diff_y) { prev_diff_y =3D diff; *y =3D read; } prev_val_y =3D read; - - } else if (channel < creads * 2 + 1) { - *z1 =3D read; - - } else if (channel < creads * 2 + 2) { - *z2 =3D read; } } } --=20 1.9.1