From: Oliver Neukum <oneukum@suse.de>
To: Benson Leung <bleung@chromium.org>
Cc: johan@kernel.org, Jiri Kosina <jkosina@suse.cz>,
linux-usb@vger.kernel.org,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sameer Nanda <snanda@chromium.org>
Subject: Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup
Date: Mon, 24 Nov 2014 10:13:15 +0100 [thread overview]
Message-ID: <1416820395.19925.4.camel@linux-0dmf.site> (raw)
In-Reply-To: <CANLzEkvcm5g_T+FsEQF2UFzS5A2u7CWgdTiEJAxidfxgAE5bHw@mail.gmail.com>
On Fri, 2014-11-21 at 17:00 -0800, Benson Leung wrote:
> If devices are already asleep with this flag enabled, that means that
> they are presently configured for remote wake.
Yes, but that doesn't matter. The drivers must be ready for a device
being resumed at any time. Remote wakeup just adds one more reason.
> Waking the device in the case of a close() is appropriate because it
> also has the effect of re-suspending the device with the capability
> disabled, as it is no longer necessary.
But there is very little to be gained by switching off remote wakeup.
The additional energy consumption devices with remote wakeup enabled
will be dwarfed by the energy needed for an additional wakeup.
Regards
Oliver
next prev parent reply other threads:[~2014-11-24 9:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 20:16 [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup Benson Leung
2014-11-13 20:41 ` Alan Stern
2014-11-13 20:44 ` Benson Leung
[not found] ` <CANLzEksGg0KyWOS+WYv_U8GzSJ4C_H0LTpdXvz8Ae-8mH6K41w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-13 21:18 ` Alan Stern
2014-11-13 21:41 ` Benson Leung
2014-11-13 22:11 ` Alan Stern
2014-11-13 22:15 ` Benson Leung
[not found] ` <CANLzEksHgo_tQiwJoUtXd0iV7tDXq0ieNrAXgtXwPtxxPBWrgw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-14 15:17 ` Alan Stern
2014-11-22 0:44 ` Benson Leung
2014-11-22 15:55 ` Alan Stern
2014-11-22 16:02 ` Alan Stern
2014-11-25 1:29 ` Benson Leung
2014-11-25 15:24 ` Alan Stern
2014-11-25 15:29 ` Benson Leung
2014-11-13 21:25 ` [PATCH v2] HID: usbhid: clear needs_remote_wakeup before usb_kill_urb Benson Leung
2014-11-14 9:08 ` [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup Oliver Neukum
2014-11-22 1:00 ` Benson Leung
2014-11-24 9:13 ` Oliver Neukum [this message]
[not found] ` <1416820395.19925.4.camel-AfvqVibwNMkMNNZnWhT/Jw@public.gmane.org>
2014-11-25 0:56 ` Benson Leung
2014-11-25 9:53 ` Oliver Neukum
-- strict thread matches above, loose matches on Subject: below --
2017-09-08 17:43 Dmitry Torokhov
2017-09-09 7:35 ` Oliver Neukum
[not found] ` <1504942552.10395.2.camel-IBi9RG/b67k@public.gmane.org>
2017-09-11 20:02 ` Benson Leung
2017-09-11 23:29 ` Benson Leung
2017-09-20 1:39 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416820395.19925.4.camel@linux-0dmf.site \
--to=oneukum@suse.de \
--cc=bleung@chromium.org \
--cc=jkosina@suse.cz \
--cc=johan@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=snanda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).