From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup Date: Mon, 24 Nov 2014 10:13:15 +0100 Message-ID: <1416820395.19925.4.camel@linux-0dmf.site> References: <1415909806-23848-1-git-send-email-bleung@chromium.org> <1415956110.2640.5.camel@linux-0dmf.site> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Benson Leung Cc: johan@kernel.org, Jiri Kosina , linux-usb@vger.kernel.org, "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sameer Nanda List-Id: linux-input@vger.kernel.org On Fri, 2014-11-21 at 17:00 -0800, Benson Leung wrote: > If devices are already asleep with this flag enabled, that means that > they are presently configured for remote wake. Yes, but that doesn't matter. The drivers must be ready for a device being resumed at any time. Remote wakeup just adds one more reason. > Waking the device in the case of a close() is appropriate because it > also has the effect of re-suspending the device with the capability > disabled, as it is no longer necessary. But there is very little to be gained by switching off remote wakeup. The additional energy consumption devices with remote wakeup enabled will be dwarfed by the energy needed for an additional wakeup. Regards Oliver